From: Christer Edwards on
On Mon, May 10, 2010 at 8:23 PM, Adam Vande More <amvandemore(a)gmail.com> wrote:
>> DISTVERSION=    3.0pre1
>> is shorter and cleaner
>>
>
> That's longer, and cleaner is debatable.

Well I've used DISTVERSION and it now reports 'looks fine.'

What is the next step?

--
Christer Edwards
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Sahil Tandon on
On Tue, 11 May 2010, Alberto Villa wrote:

> On Tuesday 11 May 2010 03:37:01 Sahil Tandon wrote:
> > Regarding portlint's FATAL output, please review Package Naming
> > Conventions in the Handbook. Specifically, "If the software version has
> > strings like ``alpha'', ``beta'', ``rc'', or ``pre'', take the first
> > letter and put it immediately after a period." So you could try
> > sometihng like:
> >
> > PORTVERSION= 3.0.p1
> > DISTNAME= ${PORTNAME}-${PORTVERSION:S/.p/pre/}
>
> DISTVERSION= 3.0pre1
> is shorter and cleaner

I appreciate the brevity, but this requires adjustment with every
PORTVERSION change. I prefer a solution that requires one less (albeit
simple) manual step; perhaps some sed-fu in DISTVERSION if the DISTNAME
example is aesthetically unpalatable. TMTOWTDI. :-)

--
Sahil Tandon <sahil(a)FreeBSD.org>
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Sahil Tandon on
On May 10, 2010, at 10:52 PM, Sahil Tandon <sahil(a)FreeBSD.org> wrote:

> On Tue, 11 May 2010, Alberto Villa wrote:
>
>> On Tuesday 11 May 2010 03:37:01 Sahil Tandon wrote:
>>> Regarding portlint's FATAL output, please review Package Naming
>>> Conventions in the Handbook. Specifically, "If the software
>>> version has
>>> strings like ``alpha'', ``beta'', ``rc'', or ``pre'', take the first
>>> letter and put it immediately after a period." So you could try
>>> sometihng like:
>>>
>>> PORTVERSION= 3.0.p1
>>> DISTNAME= ${PORTNAME}-${PORTVERSION:S/.p/pre/}
>>
>> DISTVERSION= 3.0pre1
>> is shorter and cleaner
>
> I appreciate the brevity, but this requires adjustment with every
> PORTVERSION change. I prefer a solution that requires one less
> (albeit
> simple) manual step; perhaps some sed-fu in DISTVERSION if the
> DISTNAME
> example is aesthetically unpalatable. TMTOWTDI. :-)

Actually, after thinking about this some more, avilla@'s DISTVERSION
tweak is more elegant and gives us the same end result with less
fiddling. Stick with that and sorry for the noise!

--
Sahil Tandon

_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Adam Vande More on
On Mon, May 10, 2010 at 9:23 PM, Adam Vande More <amvandemore(a)gmail.com>wrote:

> On Mon, May 10, 2010 at 9:08 PM, Alberto Villa <avilla(a)freebsd.org> wrote:
>
>> > PORTVERSION= 3.0.p1
>> > DISTNAME= ${PORTNAME}-${PORTVERSION:S/.p/pre/}
>>
>> DISTVERSION= 3.0pre1
>> is shorter and cleaner
>>
>
> That's longer, and cleaner is debatable.
>

Opps, I notice the diff now.

--
Adam Vande More
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Alberto Villa on
glad to be of help :)

On 5/11/10, Adam Vande More <amvandemore(a)gmail.com> wrote:
> On Mon, May 10, 2010 at 9:23 PM, Adam Vande More
> <amvandemore(a)gmail.com>wrote:
>
>> On Mon, May 10, 2010 at 9:08 PM, Alberto Villa <avilla(a)freebsd.org> wrote:
>>
>>> > PORTVERSION= 3.0.p1
>>> > DISTNAME= ${PORTNAME}-${PORTVERSION:S/.p/pre/}
>>>
>>> DISTVERSION= 3.0pre1
>>> is shorter and cleaner
>>>
>>
>> That's longer, and cleaner is debatable.
>>
>
> Opps, I notice the diff now.
>
> --
> Adam Vande More
>


--
Alberto Villa, FreeBSD committer <avilla(a)FreeBSD.org>
http://people.FreeBSD.org/~avilla
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"