dividing money by money
in [PgSql]
|
From: Andy Balholm on 1 Jun 2010 10:55 Thanks for the explanation of CommitFests. >> On May 30, 2010, at 6:53 AM, Kevin Grittner wrote: >>> You would then generate a diff in context format and post to the >>> -hackers list with that file as an attachment. I made my diff with src/tools/make_diff, as suggested in the Developer FAQ. But using git diff would be less hassle. Do the diffs from git diff work just as well? -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Bruce Momjian on 1 Jun 2010 10:58 Andy Balholm wrote: > Thanks for the explanation of CommitFests. > > >> On May 30, 2010, at 6:53 AM, Kevin Grittner wrote: > >>> You would then generate a diff in context format and post to the > >>> -hackers list with that file as an attachment. > > I made my diff with src/tools/make_diff, as suggested in the > Developer FAQ. But using git diff would be less hassle. Do the > diffs from git diff work just as well? Yes, of course. -- Bruce Momjian <bruce(a)momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + None of us is going to be here forever. + -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Stefan Kaltenbrunner on 1 Jun 2010 11:00 Andy Balholm wrote: > Thanks for the explanation of CommitFests. > >>> On May 30, 2010, at 6:53 AM, Kevin Grittner wrote: >>>> You would then generate a diff in context format and post to the >>>> -hackers list with that file as an attachment. > > I made my diff with src/tools/make_diff, as suggested in the Developer FAQ. But using git diff would be less hassle. Do the diffs from git diff work just as well? context diffs are preferred - for advise on how to create them: http://wiki.postgresql.org/wiki/Working_with_Git#Context_diffs_with_Git Stefan -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: "Kevin Grittner" on 1 Jun 2010 11:09 Andy Balholm <andy(a)balholm.com> wrote: > I made my diff with src/tools/make_diff, as suggested in the > Developer FAQ. But using git diff would be less hassle. Do the > diffs from git diff work just as well? I agree about the git diff being easier; however, those files are in unified format and some committers prefer to read the context format, so I'd recommend piping it through filterdiff --format=context. Personally, although I submit patches in context format, I keep the unified copy around because I find the method names from git useful and I like to be able to view the patch through kompare, which doesn't seem to like the context format as well. -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Alvaro Herrera on 1 Jun 2010 11:30
Excerpts from Kevin Grittner's message of mar jun 01 11:09:38 -0400 2010: > I agree about the git diff being easier; however, those files are in > unified format and some committers prefer to read the context > format, so I'd recommend piping it through filterdiff > --format=context. Personally, although I submit patches in context > format, I keep the unified copy around because I find the method > names from git useful Hmm, cvs diff -Ncp does show method names too, so this is probably filterdiff removing them. BTW maybe the developer faq could use all the info gathered in this thread. -- Álvaro Herrera <alvherre(a)commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |