dividing money by money
in [PgSql]
|
From: "Kevin Grittner" on 30 May 2010 09:53 Andy Balholm wrote: On May 26, 2010, at 11:18 AM, Kevin Grittner wrote: >> Do you want to package this up as a patch for 9.1? If not, is it >> OK if I do? > I'm not quite sure how to go about changing it from an add-on > function to a built-in one. So if you want to do that, go ahead. If > you'd rather I did, just tell me how it's done. You would basically move the functions and their prototypes to cash.c and cash.h, and then (instead of CREATE FUNCTION, etc.) add corresponding entries to pg_proc.h and pg_operator.h. (If I'm missing something, someone please jump in.) Of course there's the issue of adding the new operators to the documentation, too. You would then generate a diff in context format and post to the -hackers list with that file as an attachment. Don't forget to add it to the "CommitFest" page: https://commitfest.postgresql.org/action/commitfest_view/open If you're going to do this, be sure to breeze through the developer's FAQ: http://wiki.postgresql.org/wiki/Developer_FAQ Of course, if that's all too daunting, I can do it, but it seems to me that you've already done the hard part (in creating working functions), so I figured it might be satisfying for you to see it through to the end. -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Andy Balholm on 30 May 2010 18:54 On May 30, 2010, at 6:53 AM, Kevin Grittner wrote: > You would basically move the functions and their prototypes to cash.c > and cash.h, and then (instead of CREATE FUNCTION, etc.) add > corresponding entries to pg_proc.h and pg_operator.h. (If I'm > missing something, someone please jump in.) Of course there's the > issue of adding the new operators to the documentation, too. How do I come up with OID numbers for my new operators and functions? -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Tom Lane on 30 May 2010 20:01 Andy Balholm <andy(a)balholm.com> writes: > How do I come up with OID numbers for my new operators and functions? Go into src/include/catalog and run the "unused_oids" script found there. Pick some. Your chances of getting numbers close to those currently in use for money-related functions are probably nil, so I'd suggest just using a consecutive range at or a bit above the last one currently in use. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Andy Balholm on 31 May 2010 17:59 On May 30, 2010, at 6:53 AM, Kevin Grittner wrote: > You would then generate a diff in context format and post to the > -hackers list with that file as an attachment. Here it is:
From: "Kevin Grittner" on 1 Jun 2010 10:43
Andy Balholm <andy(a)balholm.com> wrote: > On May 30, 2010, at 6:53 AM, Kevin Grittner wrote: >> You would then generate a diff in context format and post to the >> -hackers list with that file as an attachment. > > Here it is: > > [context diff attachment] > > I can't add it to the CommitFest page, since I don't have web > access, just e-mail. Could you please take care of that part? Done. I'll keep it up-to-date as other posts occur. > (What is the CommitFest page, anyway?) "A CommitFest is a periodic break to PostgreSQL development that focuses on patch review and commit rather than new development." These are held so that all the work for a release gets relatively prompt review and feedback, and so that work for a release doesn't pile up until the end of the release cycle. During these periods developers are asked to review and test the patches submitted by others. The hope is that this will also reduce the burden on those who do the final review and commit. The CF page is used to keep track of submitted patches and their status, to help manage the process. When we're not trying to put together a major release CFs tend to run for one month each with a one month gap between them. Due to the process of getting a release out the door, though, the last one started on the 15th of January and the next one starts on the 15th of July. We're going to try to get some early review on as many patches as possible starting the 15th of June, but the committers probably won't have much time to deal with any of this until the official CF, so we're calling this (less formal) period a "Review Fest". The peer review process often results in discussion on the -hackers list and/or requests for some sort of modification before commit. Most patches wind up getting committed, although some are returned with feedback (in hopes that the submitter will make some change and submit to a later cycle) or rejected (if they are determined by the community not to be useful changes). By the way, I signed on to review your patch. -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |