Prev: Use TASK_KILLABLE instead TASK_UNINTERRUPTIBLE
Next: [PATCH] nomadik_nand.c: use resource_size()
From: Arnd Bergmann on 14 Dec 2009 15:20
On Monday 14 December 2009 17:10:05 Randy Dunlap wrote:
>
> From: Randy Dunlap <randy.dunlap(a)oracle.com>
>
> Fix build failure when CONFIG_BLOCK=n:
>
> fs/compat_ioctl.c:1604: error: 'SG_SET_TRANSFORM' undeclared
>
> Signed-off-by: Randy Dunlap <randy.dunlap(a)oracle.com>

Your patch is obviously correct, but I wonder if we could just drop
the line completely, given that no driver in the kernel actually
implements this ioctl command. It was part of the ide-scsi driver
until 2.6.28, but that driver was removed in 2.6.29.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Randy Dunlap on 15 Dec 2009 14:40
On Mon, 14 Dec 2009 20:16:13 +0000 Arnd Bergmann wrote:

> On Monday 14 December 2009 17:10:05 Randy Dunlap wrote:
> >
> > From: Randy Dunlap <randy.dunlap(a)oracle.com>
> >
> > Fix build failure when CONFIG_BLOCK=n:
> >
> > fs/compat_ioctl.c:1604: error: 'SG_SET_TRANSFORM' undeclared
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap(a)oracle.com>
>
> Your patch is obviously correct, but I wonder if we could just drop
> the line completely, given that no driver in the kernel actually
> implements this ioctl command. It was part of the ide-scsi driver
> until 2.6.28, but that driver was removed in 2.6.29.

I checked with Jens, he says yes, drop that case.
Do you want to do that or should I send another patch?

thanks,
---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: Use TASK_KILLABLE instead TASK_UNINTERRUPTIBLE
Next: [PATCH] nomadik_nand.c: use resource_size()