From: Christer Solskogen on
On Sun, Feb 21, 2010 at 10:44 AM, Dominic Fandrey <kamikaze(a)bsdforen.de> wrote:

> So the right solution might be for the "package-noinstall" target to
> use "pkg_create -b" and additionally create the symlinks.
>
> I do not like have different code for doing the same thing in this
> context.
>

Does the target 'package' use pkg_create?

--
chs,
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Dominic Fandrey on
On 21/02/2010 10:47, Christer Solskogen wrote:
> On Sun, Feb 21, 2010 at 10:44 AM, Dominic Fandrey <kamikaze(a)bsdforen.de> wrote:
>
>> So the right solution might be for the "package-noinstall" target to
>> use "pkg_create -b" and additionally create the symlinks.
>>
>> I do not like have different code for doing the same thing in this
>> context.
>>
>
> Does the target 'package' use pkg_create?

Yes it does.

I have a patch that should do the trick. Would you be so kind to test
it?
http://www.home.hs-karlsruhe.de/~fado0001/patch-ports-Mk-bsd.port.mk.txt

If it does, please open a PR and post the number here. wxs and I can
post our patches there and portmgr can decide.

--
A: Because it fouls the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Dominic Fandrey on
On 21/02/2010 11:02, Dominic Fandrey wrote:
> On 21/02/2010 10:47, Christer Solskogen wrote:
>> On Sun, Feb 21, 2010 at 10:44 AM, Dominic Fandrey <kamikaze(a)bsdforen.de> wrote:
>>
>>> So the right solution might be for the "package-noinstall" target to
>>> use "pkg_create -b" and additionally create the symlinks.
>>>
>>> I do not like have different code for doing the same thing in this
>>> context.
>>
>> Does the target 'package' use pkg_create?
>
> Yes it does.

More precisely, do-package does.

> I have a patch that should do the trick. Would you be so kind to test
> it?
> http://www.home.hs-karlsruhe.de/~fado0001/patch-ports-Mk-bsd.port.mk.txt
>
> If it does, please open a PR and post the number here. wxs and I can
> post our patches there and portmgr can decide.

After testing my patch to my satisfaction I went ahead and opened a PR:
http://www.freebsd.org/cgi/query-pr.cgi?pr=144164

--
A: Because it fouls the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"

From: Wesley Shields on
On Sun, Feb 21, 2010 at 12:01:50PM +0100, Dominic Fandrey wrote:
> On 21/02/2010 11:02, Dominic Fandrey wrote:
> > On 21/02/2010 10:47, Christer Solskogen wrote:
> >> On Sun, Feb 21, 2010 at 10:44 AM, Dominic Fandrey <kamikaze(a)bsdforen.de> wrote:
> >>
> >>> So the right solution might be for the "package-noinstall" target to
> >>> use "pkg_create -b" and additionally create the symlinks.
> >>>
> >>> I do not like have different code for doing the same thing in this
> >>> context.
> >>
> >> Does the target 'package' use pkg_create?
> >
> > Yes it does.
>
> More precisely, do-package does.
>
> > I have a patch that should do the trick. Would you be so kind to test
> > it?
> > http://www.home.hs-karlsruhe.de/~fado0001/patch-ports-Mk-bsd.port.mk.txt
> >
> > If it does, please open a PR and post the number here. wxs and I can
> > post our patches there and portmgr can decide.
>
> After testing my patch to my satisfaction I went ahead and opened a PR:
> http://www.freebsd.org/cgi/query-pr.cgi?pr=144164

No need for my patch to make it into the PR. I like your solution better. ;)

-- WXS
_______________________________________________
freebsd-ports(a)freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"