make package-noinstall does not include rc.d scripts?
in [Ports]
|
Prev: lang/gcc44 Inconsistant package list. Leftover files.
Next: FreeBSD unmaintained ports which are currently marked forbidden
From: Christer Solskogen on 20 Feb 2010 10:55 Hi! I've just discovered the make option "make package-noinstall" which makes a tbz in /usr/ports/packages from a already installed package. But I've also found a bug(?) with that option. The package it creates seems not to include rc.d script which will be included if you use "make package" I've tried this now with two ports (stunnel and mysql51-server) - but I guess that it will happen to other ports as well. -- chs, _______________________________________________ freebsd-ports(a)freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"
From: Wesley Shields on 20 Feb 2010 16:51 On Sat, Feb 20, 2010 at 04:55:58PM +0100, Christer Solskogen wrote: > Hi! > > I've just discovered the make option "make package-noinstall" which > makes a tbz in /usr/ports/packages from a already installed package. > But I've also found a bug(?) with that option. The package it creates > seems not to include rc.d script which will be included if you use > "make package" > I've tried this now with two ports (stunnel and mysql51-server) - but > I guess that it will happen to other ports as well. I tested it with devel/git and it looks like a bug to me. I've got a patch which should fix it[1]. It's basically a copy/paste of the install-rc-script target into the do-package target and removing the two lines that actually install the script. A better solution may be to have one target install the rc script and one target add it to the plist. That way the add-to-plist target can be effectively shared. Minimizing the chances that changes in one do not reflect into the other. Does anyone have any opinions on this? If not I'll open a PR for portmgr. [1]: http://people.freebsd.org/~wxs/package-noinstall-rc-script.diff -- WXS _______________________________________________ freebsd-ports(a)freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"
From: Dominic Fandrey on 21 Feb 2010 03:12 On 20/02/2010 16:55, Christer Solskogen wrote: > Hi! > > I've just discovered the make option "make package-noinstall" which > makes a tbz in /usr/ports/packages from a already installed package. > But I've also found a bug(?) with that option. The package it creates > seems not to include rc.d script which will be included if you use > "make package" > I've tried this now with two ports (stunnel and mysql51-server) - but > I guess that it will happen to other ports as well. Does the same problem appear with "pkg_create -b"? I'd expect such a target simply calling that and if that would be broken it would affect the use of almost every package maintenance tool for the FreeBSD ports. -- A: Because it fouls the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing on usenet and in e-mail? _______________________________________________ freebsd-ports(a)freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"
From: Christer Solskogen on 21 Feb 2010 04:33 On Sun, Feb 21, 2010 at 9:12 AM, Dominic Fandrey <kamikaze(a)bsdforen.de> wrote: > Does the same problem appear with "pkg_create -b"? No. pkg_create -b does the job. The only "problem" with pkg_create is that it dont create packages and symlinks in /usr/ports/packages/. -- chs, _______________________________________________ freebsd-ports(a)freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org"
From: Dominic Fandrey on 21 Feb 2010 04:44
On 21/02/2010 10:33, Christer Solskogen wrote: > On Sun, Feb 21, 2010 at 9:12 AM, Dominic Fandrey <kamikaze(a)bsdforen.de> wrote: > >> Does the same problem appear with "pkg_create -b"? > > No. pkg_create -b does the job. The only "problem" with pkg_create is > that it dont create packages and symlinks in /usr/ports/packages/. So the right solution might be for the "package-noinstall" target to use "pkg_create -b" and additionally create the symlinks. I do not like have different code for doing the same thing in this context. -- A: Because it fouls the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing on usenet and in e-mail? _______________________________________________ freebsd-ports(a)freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscribe(a)freebsd.org" |