message clarifications
in [PgSql]
|
Prev: pgindent bizarreness
Next: [HACKERS] pgindent cleanup
From: Peter Eisentraut on 4 Apr 2010 16:27 On lör, 2010-04-03 at 11:13 -0400, Tom Lane wrote: > Peter Eisentraut <peter_e(a)gmx.net> writes: > > The following messages from the postgres catalog either appear to be > > internal errors that should be marked differently, or they are in my > > estimation unintelligible to users and should be rephrased. > > > #: commands/async.c:1424 > > msgid "pg_notify queue is %.0f%% full" > > This one is probably my responsibility (the others all look like Simon's > code). What do you not like about it, exactly? Perhaps it should be > "NOTIFY queue is x% full"? Yeah, that plus some hints maybe. "pg_notify" had me confused initially, since it looks like a system catalog table name. -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Tom Lane on 4 Apr 2010 20:43 Peter Eisentraut <peter_e(a)gmx.net> writes: > On lör, 2010-04-03 at 11:13 -0400, Tom Lane wrote: >> This one is probably my responsibility (the others all look like Simon's >> code). What do you not like about it, exactly? Perhaps it should be >> "NOTIFY queue is x% full"? > Yeah, that plus some hints maybe. "pg_notify" had me confused > initially, since it looks like a system catalog table name. OK, I did this: Index: async.c =================================================================== RCS file: /cvsroot/pgsql/src/backend/commands/async.c,v retrieving revision 1.155 diff -c -r1.155 async.c *** async.c 26 Feb 2010 02:00:37 -0000 1.155 --- async.c 5 Apr 2010 00:38:03 -0000 *************** *** 1421,1432 **** } ereport(WARNING, ! (errmsg("pg_notify queue is %.0f%% full", fillDegree * 100), (minPid != InvalidPid ? ! errdetail("PID %d is among the slowest backends.", minPid) : 0), (minPid != InvalidPid ? ! errhint("Cleanup can only proceed if this backend ends its current transaction.") : 0))); asyncQueueControl->lastQueueFillWarn = t; --- 1421,1432 ---- } ereport(WARNING, ! (errmsg("NOTIFY queue is %.0f%% full", fillDegree * 100), (minPid != InvalidPid ? ! errdetail("The server process with PID %d is among those with the oldest transactions.", minPid) : 0), (minPid != InvalidPid ? ! errhint("The NOTIFY queue cannot be emptied until that process ends its current transaction.") : 0))); asyncQueueControl->lastQueueFillWarn = t; regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Simon Riggs on 6 Apr 2010 05:30 On Sat, 2010-04-03 at 11:00 +0300, Peter Eisentraut wrote: > The following messages from the postgres catalog either appear to be > internal errors that should be marked differently, or they are in my > estimation unintelligible to users and should be rephrased. > #: storage/ipc/procarray.c:2224 > msgid "record known xact %u latestObservedXid %u" > > > #: storage/ipc/procarray.c:2257 > msgid "recording unobserved xid %u (latestObservedXid %u)" > > > #: storage/ipc/procarray.c:2379 > msgid "too many KnownAssignedXids" > > > #: storage/ipc/standby.c:861 > msgid "" > "snapshot of %u running transactions overflowed (lsn %X/%X oldest " > "xid %u next xid %u)" > > > #: storage/ipc/standby.c:868 > msgid "" > "snapshot of %u running transaction ids (lsn %X/%X oldest xid %u " > "next xid %u)" These are all DEBUG messages. Can you explain "marked differently" so I can do that for you? -- Simon Riggs www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Peter Eisentraut on 6 Apr 2010 05:44 On tis, 2010-04-06 at 10:30 +0100, Simon Riggs wrote: > These are all DEBUG messages. Can you explain "marked differently" so I > can do that for you? Then it would be better to convert them to use elog() instead of ereport(). -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Simon Riggs on 6 Apr 2010 06:03
On Tue, 2010-04-06 at 12:44 +0300, Peter Eisentraut wrote: > On tis, 2010-04-06 at 10:30 +0100, Simon Riggs wrote: > > These are all DEBUG messages. Can you explain "marked differently" so I > > can do that for you? > > Then it would be better to convert them to use elog() instead of > ereport(). Will do -- Simon Riggs www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |