message clarifications
in [PgSql]
|
Prev: pgindent bizarreness
Next: [HACKERS] pgindent cleanup
From: Tom Lane on 6 Apr 2010 09:57 Peter Eisentraut <peter_e(a)gmx.net> writes: > On tis, 2010-04-06 at 10:30 +0100, Simon Riggs wrote: >> These are all DEBUG messages. Can you explain "marked differently" so I >> can do that for you? > Then it would be better to convert them to use elog() instead of > ereport(). Or use errmsg_internal instead of errmsg. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Simon Riggs on 6 Apr 2010 10:11 On Tue, 2010-04-06 at 09:57 -0400, Tom Lane wrote: > Peter Eisentraut <peter_e(a)gmx.net> writes: > > On tis, 2010-04-06 at 10:30 +0100, Simon Riggs wrote: > >> These are all DEBUG messages. Can you explain "marked differently" so I > >> can do that for you? > > > Then it would be better to convert them to use elog() instead of > > ereport(). > > Or use errmsg_internal instead of errmsg. I've changed them to elog() before you said this. Would you like me to change them to errmsg_internal or do you mean "...as an option in the future"? -- Simon Riggs www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Tom Lane on 6 Apr 2010 10:13
Simon Riggs <simon(a)2ndQuadrant.com> writes: > On Tue, 2010-04-06 at 09:57 -0400, Tom Lane wrote: >> Or use errmsg_internal instead of errmsg. > I've changed them to elog() before you said this. Would you like me to > change them to errmsg_internal or do you mean "...as an option in the > future"? It's just a different option. elog for debug messages is a well established practice, but if you wanted something that looked more like ereport, you could hide the messages from translation with the above. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |