From: Magnus Hagander on
On Fri, Jul 2, 2010 at 8:35 AM, KaiGai Kohei <kaigai(a)ak.jp.nec.com> wrote:
> (2010/07/01 11:30), Peter Eisentraut wrote:
> I have a question.
>
> The pqGetpwuid() is enclosed by #ifndef WIN32 ... #endif, although
> this patch encloses the section to obtain user id of the peer by
> #ifdef HAVE_UNIX_SOCKETS ... #endif.
>
> Is there any possibilities that both WIN32 and HAVE_UNIX_SOCKETS are
> set concurrently? If possible, the libpq may try to call undefined
> function, then build will be failed.

Win32 never has HAVE_UNIX_SOCKET.

Cygwin might though, I recall some old discussion about that - can't
remember the outcome though, and I can't find it right now.

> I'd like someone to try to build with this patch on win32 platform,
> and report it.

I think cygwin may be the more important one here.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Peter Eisentraut on
On fre, 2010-07-02 at 09:16 +0100, Magnus Hagander wrote:
> On Fri, Jul 2, 2010 at 8:35 AM, KaiGai Kohei <kaigai(a)ak.jp.nec.com> wrote:
> > (2010/07/01 11:30), Peter Eisentraut wrote:
> > I have a question.
> >
> > The pqGetpwuid() is enclosed by #ifndef WIN32 ... #endif, although
> > this patch encloses the section to obtain user id of the peer by
> > #ifdef HAVE_UNIX_SOCKETS ... #endif.
> >
> > Is there any possibilities that both WIN32 and HAVE_UNIX_SOCKETS are
> > set concurrently? If possible, the libpq may try to call undefined
> > function, then build will be failed.
>
> Win32 never has HAVE_UNIX_SOCKET.
>
> Cygwin might though, I recall some old discussion about that - can't
> remember the outcome though, and I can't find it right now.

Cygwin doesn't define WIN32 anyway.



--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Andrew Dunstan on


Peter Eisentraut wrote:
>>> Is there any possibilities that both WIN32 and HAVE_UNIX_SOCKETS are
>>> set concurrently? If possible, the libpq may try to call undefined
>>> function, then build will be failed.
>>>
>> Win32 never has HAVE_UNIX_SOCKET.
>>
>> Cygwin might though, I recall some old discussion about that - can't
>> remember the outcome though, and I can't find it right now.
>>
>
> Cygwin doesn't define WIN32 anyway.
>
>

Indeed, and we've been very careful to keep it that way.

cheers

andrew


--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: KaiGai Kohei on
(2010/07/03 1:39), Andrew Dunstan wrote:
>
>
> Peter Eisentraut wrote:
>>>> Is there any possibilities that both WIN32 and HAVE_UNIX_SOCKETS are
>>>> set concurrently? If possible, the libpq may try to call undefined
>>>> function, then build will be failed.
>>> Win32 never has HAVE_UNIX_SOCKET.
>>>
>>> Cygwin might though, I recall some old discussion about that - can't
>>> remember the outcome though, and I can't find it right now.
>>
>> Cygwin doesn't define WIN32 anyway.
>>
>
> Indeed, and we've been very careful to keep it that way.
>

Sorry for the late responding.

I marked this patch 'ready for committer'.

Thanks,
--
KaiGai Kohei <kaigai(a)ak.jp.nec.com>

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers