Prev: 'replication' keyword on .pgpass (Streaming Replication)
Next: [HACKERS] unresolved bugs
From: Stefan Kaltenbrunner on 6 Jan 2010 15:21
Tom Lane wrote:
> John Naylor <jcnaylor(a)gmail.com> writes:
>> Here's a fix. Sorry, I didn't realize it was ever called without a
>> version number.
>
> It's not supposed to be. If it fails to put the correct version number
> into the .bki file, initdb will spit up. This is really a makefile bug,
> not genbki's fault.

really? there are provisions withing genbki.pl that are supposed to
provide a proper error message(and would have likely helped to find the
issue in that case as well):

die "Version not specified or wrong format.\n" if !defined $major_version;

however due to the way the current checks are executed you won't
actually see that error...


Stefan

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Tom Lane on 6 Jan 2010 15:42
Stefan Kaltenbrunner <stefan(a)kaltenbrunner.cc> writes:
> really? there are provisions withing genbki.pl that are supposed to
> provide a proper error message(and would have likely helped to find the
> issue in that case as well):
> die "Version not specified or wrong format.\n" if !defined $major_version;
> however due to the way the current checks are executed you won't
> actually see that error...

Good point, the way that the error checking is done in the script leaves
a lot to be desired there.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

First  |  Prev  | 
Pages: 1 2
Prev: 'replication' keyword on .pgpass (Streaming Replication)
Next: [HACKERS] unresolved bugs