Prev: 'replication' keyword on .pgpass (Streaming Replication)
Next: [HACKERS] unresolved bugs
From: Tom Lane on 6 Jan 2010 13:41
Stefan Kaltenbrunner <stefan(a)kaltenbrunner.cc> writes:
> Looks like somebody broke the snapshot generation script again:

[ scratches head... ] "make dist" works for me. Can you get a
trace indicating what command was used to call genbki.pl?

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Stefan Kaltenbrunner on 6 Jan 2010 14:18
Tom Lane wrote:
> Stefan Kaltenbrunner <stefan(a)kaltenbrunner.cc> writes:
>> Looks like somebody broke the snapshot generation script again:
>
> [ scratches head... ] "make dist" works for me. Can you get a
> trace indicating what command was used to call genbki.pl?

heh that's a nice one the snapshot generation script uses "
gmake -s VERSION=snapshot dist" and that leads to getting "
--set-version=snapshot" passed to genbki.pl which fails the regex there
and the if() falls through to the usage().


Stefan

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: John Naylor on 6 Jan 2010 14:41
Here's a fix. Sorry, I didn't realize it was ever called without a
version number.

On Wed, Jan 6, 2010 at 11:18 AM, Stefan Kaltenbrunner
> heh that's a nice one the snapshot generation script uses "
> gmake -s VERSION=snapshot dist" and that leads to getting "
> --set-version=snapshot" passed to genbki.pl which fails the regex there and
> the if() falls through to the usage().
From: Tom Lane on 6 Jan 2010 14:43
Stefan Kaltenbrunner <stefan(a)kaltenbrunner.cc> writes:
> Tom Lane wrote:
>> [ scratches head... ] "make dist" works for me. Can you get a
>> trace indicating what command was used to call genbki.pl?

> heh that's a nice one the snapshot generation script uses "
> gmake -s VERSION=snapshot dist" and that leads to getting "
> --set-version=snapshot" passed to genbki.pl which fails the regex there
> and the if() falls through to the usage().

Huh ... that doesn't make any sense, because the previous shell-script
version also spits up on non-numeric VERSION. How did it work before?

[... thinks ...] Oh: it didn't, because we didn't use to try to call
this during distprep. We'd not want "snapshot" as the version number
in postgres.bki anyway. So we need to change the makefile to not rely
on VERSION for this, I guess. Will fix.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Tom Lane on 6 Jan 2010 15:17
John Naylor <jcnaylor(a)gmail.com> writes:
> Here's a fix. Sorry, I didn't realize it was ever called without a
> version number.

It's not supposed to be. If it fails to put the correct version number
into the .bki file, initdb will spit up. This is really a makefile bug,
not genbki's fault.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

 |  Next  |  Last
Pages: 1 2
Prev: 'replication' keyword on .pgpass (Streaming Replication)
Next: [HACKERS] unresolved bugs