Prev: [PATCH 03/22] Constify struct backlight_ops for 2.6.32-git-053fe57ac v2
Next: [PATCH 0/7] tracing: Fix bugs in string filters.
From: Alex Chiang on 16 Dec 2009 02:00 * Dmitry Torokhov <dmitry.torokhov(a)gmail.com>: > On Tue, Dec 15, 2009 at 06:05:06PM -0700, Alex Chiang wrote: > > * Dmitry Torokhov <dmitry.torokhov(a)gmail.com>: > > > > > > The updated patch is below. > > > > > > -- > > > Dmitry > > > > Should I test this one or wait one more iteration to address > > Takashi's last comments? > > > > Actually I think we took the wrong direction with the original patch and > we should do what other buttonless devices (bcm5974) do: report touchpad > click as left button and have Synaptics X driver provide enhanced > support. This way we can have both modes (ClickZones and ClickButtons) > and users will get to chose (provided that someone takes time to add > that support to Synaptics driver of course ;) ). > > Could you tell me if the below works for you? Left clicks work. Right/middle do not (as expected, I guess). I liked the behaviour of Takashi's patch a little better wrt what happens when you try to click/drag, because he disabled movement in the click area. My vodka consumption is minimal and I don't have the shakes, but I found it difficult to precisely hit the edge of a window and click / drag to resize... /ac -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Dmitry Torokhov on 16 Dec 2009 02:00 On Wed, Dec 16, 2009 at 07:50:54AM +0100, Takashi Iwai wrote: > At Tue, 15 Dec 2009 18:59:34 -0800, > Dmitry Torokhov wrote: > > > > On Tue, Dec 15, 2009 at 06:05:06PM -0700, Alex Chiang wrote: > > > * Dmitry Torokhov <dmitry.torokhov(a)gmail.com>: > > > > > > > > The updated patch is below. > > > > > > > > -- > > > > Dmitry > > > > > > Should I test this one or wait one more iteration to address > > > Takashi's last comments? > > > > > > > Actually I think we took the wrong direction with the original patch and > > we should do what other buttonless devices (bcm5974) do: report touchpad > > click as left button and have Synaptics X driver provide enhanced > > support. This way we can have both modes (ClickZones and ClickButtons) > > and users will get to chose (provided that someone takes time to add > > that support to Synaptics driver of course ;) ). > > My concern is, still, how would you identify this device. Will you > extend also some ioctls to expose caps and extcaps? Otherwise it's > difficult to identify this device automatically from the user-space. > No.. Synaptics without right button == ClickPad. > The user-space can know that it's button-less, yes. But, how can it > know whether the device should be emulated via ClickZone? > We can use a driver option to x11 synaptics driver for that, as I > already sent you another patch. However, the driver option is > nowadays not preferred because xorg.conf is being dead on new > systems... Driver still takes options, from UDEV/HAL. We could pick one behavior by default and ovverride, by box vendor/model (DMI). > > Or maybe HAL (or whatever upcoming one) can check the vendor/product > id of the machine (not the device) to provide the information. OTOH > this will also need frequent updates. Hopefully vendors won;t be flip/flopping between ClickZone and ClickButtons too much. Still option is better than hardcoding ClickZone for everyone. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Dmitry Torokhov on 16 Dec 2009 02:10 On Tue, Dec 15, 2009 at 11:52:00PM -0700, Alex Chiang wrote: > * Dmitry Torokhov <dmitry.torokhov(a)gmail.com>: > > On Tue, Dec 15, 2009 at 06:05:06PM -0700, Alex Chiang wrote: > > > * Dmitry Torokhov <dmitry.torokhov(a)gmail.com>: > > > > > > > > The updated patch is below. > > > > > > > > -- > > > > Dmitry > > > > > > Should I test this one or wait one more iteration to address > > > Takashi's last comments? > > > > > > > Actually I think we took the wrong direction with the original patch and > > we should do what other buttonless devices (bcm5974) do: report touchpad > > click as left button and have Synaptics X driver provide enhanced > > support. This way we can have both modes (ClickZones and ClickButtons) > > and users will get to chose (provided that someone takes time to add > > that support to Synaptics driver of course ;) ). > > > > Could you tell me if the below works for you? > > Left clicks work. Right/middle do not (as expected, I guess). > > I liked the behaviour of Takashi's patch a little better wrt what > happens when you try to click/drag, because he disabled movement > in the click area. Are the clicks register only in that special area? Reading Synaptics product description it sounds like entire surface should be clickable. > My vodka consumption is minimal and I don't have the shakes, but > I found it difficult to precisely hit the edge of a window and > click / drag to resize... > -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Takashi Iwai on 16 Dec 2009 02:20 At Tue, 15 Dec 2009 22:56:53 -0800, Dmitry Torokhov wrote: > > On Wed, Dec 16, 2009 at 07:50:54AM +0100, Takashi Iwai wrote: > > At Tue, 15 Dec 2009 18:59:34 -0800, > > Dmitry Torokhov wrote: > > > > > > On Tue, Dec 15, 2009 at 06:05:06PM -0700, Alex Chiang wrote: > > > > * Dmitry Torokhov <dmitry.torokhov(a)gmail.com>: > > > > > > > > > > The updated patch is below. > > > > > > > > > > -- > > > > > Dmitry > > > > > > > > Should I test this one or wait one more iteration to address > > > > Takashi's last comments? > > > > > > > > > > Actually I think we took the wrong direction with the original patch and > > > we should do what other buttonless devices (bcm5974) do: report touchpad > > > click as left button and have Synaptics X driver provide enhanced > > > support. This way we can have both modes (ClickZones and ClickButtons) > > > and users will get to chose (provided that someone takes time to add > > > that support to Synaptics driver of course ;) ). > > > > My concern is, still, how would you identify this device. Will you > > extend also some ioctls to expose caps and extcaps? Otherwise it's > > difficult to identify this device automatically from the user-space. > > > > No.. Synaptics without right button == ClickPad. So, is there only Clickpad device that has a single button? No other option? > > The user-space can know that it's button-less, yes. But, how can it > > know whether the device should be emulated via ClickZone? > > We can use a driver option to x11 synaptics driver for that, as I > > already sent you another patch. However, the driver option is > > nowadays not preferred because xorg.conf is being dead on new > > systems... > > Driver still takes options, from UDEV/HAL. We could pick one behavior > by default and ovverride, by box vendor/model (DMI). > > > > > Or maybe HAL (or whatever upcoming one) can check the vendor/product > > id of the machine (not the device) to provide the information. OTOH > > this will also need frequent updates. > > Hopefully vendors won;t be flip/flopping between ClickZone and > ClickButtons too much. Still option is better than hardcoding ClickZone > for everyone. Yeah, I agree that hard-coding isn't good, and that's why I first posted separated patches. OTOH, the kernel-side hack makes the device working *as is* even without changing anything else. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Dmitry Torokhov on 16 Dec 2009 03:30 On Wed, Dec 16, 2009 at 08:14:15AM +0100, Takashi Iwai wrote: > At Tue, 15 Dec 2009 22:56:53 -0800, > Dmitry Torokhov wrote: > > > > On Wed, Dec 16, 2009 at 07:50:54AM +0100, Takashi Iwai wrote: > > > At Tue, 15 Dec 2009 18:59:34 -0800, > > > Dmitry Torokhov wrote: > > > > > > > > On Tue, Dec 15, 2009 at 06:05:06PM -0700, Alex Chiang wrote: > > > > > * Dmitry Torokhov <dmitry.torokhov(a)gmail.com>: > > > > > > > > > > > > The updated patch is below. > > > > > > > > > > > > -- > > > > > > Dmitry > > > > > > > > > > Should I test this one or wait one more iteration to address > > > > > Takashi's last comments? > > > > > > > > > > > > > Actually I think we took the wrong direction with the original patch and > > > > we should do what other buttonless devices (bcm5974) do: report touchpad > > > > click as left button and have Synaptics X driver provide enhanced > > > > support. This way we can have both modes (ClickZones and ClickButtons) > > > > and users will get to chose (provided that someone takes time to add > > > > that support to Synaptics driver of course ;) ). > > > > > > My concern is, still, how would you identify this device. Will you > > > extend also some ioctls to expose caps and extcaps? Otherwise it's > > > difficult to identify this device automatically from the user-space. > > > > > > > No.. Synaptics without right button == ClickPad. > > So, is there only Clickpad device that has a single button? > No other option? > I have not seen any other Synaptics devices using less than 2 buttons. > > > The user-space can know that it's button-less, yes. But, how can it > > > know whether the device should be emulated via ClickZone? > > > We can use a driver option to x11 synaptics driver for that, as I > > > already sent you another patch. However, the driver option is > > > nowadays not preferred because xorg.conf is being dead on new > > > systems... > > > > Driver still takes options, from UDEV/HAL. We could pick one behavior > > by default and ovverride, by box vendor/model (DMI). > > > > > > > > Or maybe HAL (or whatever upcoming one) can check the vendor/product > > > id of the machine (not the device) to provide the information. OTOH > > > this will also need frequent updates. > > > > Hopefully vendors won;t be flip/flopping between ClickZone and > > ClickButtons too much. Still option is better than hardcoding ClickZone > > for everyone. > > Yeah, I agree that hard-coding isn't good, and that's why I first > posted separated patches. OTOH, the kernel-side hack makes the device > working *as is* even without changing anything else. > For "ClickZone" - yes, but not all users would want this I guess and not all laptops will have that zone marked. Pushing it off to userspace gives more flexibility, including the ability to change zone size, etc. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
First
|
Prev
|
Next
|
Last
Pages: 1 2 3 4 5 Prev: [PATCH 03/22] Constify struct backlight_ops for 2.6.32-git-053fe57ac v2 Next: [PATCH 0/7] tracing: Fix bugs in string filters. |