-tip: origin tree boot crash
in [Kernel]
|
Prev: [PATCH] backlight: lcd: Add Epson L4F00242T03 LCD driver.
Next: improve the performance of large sequential write NFS workloads
From: Paul Rolland on 28 Dec 2009 11:40 Hello, On Mon, 28 Dec 2009 16:02:12 +0100 Paul Rolland (ポール・ロラン) <rol(a)witbe.net> wrote: > Message from syslogd(a)tux at Dec 28 16:00:22 ... > kernel:CR2: 0000000100000024 > Dec 28 16:00:22 tux kernel: ACPI: WMI: Mapper loaded > Dec 28 16:00:22 tux kernel: input: Dell WMI hotkeys > as /devices/virtual/input/input13 Dec 28 16:00:22 tux kernel: BUG: unable > to handle kernel paging request at 0000000100000024 Dec 28 16:00:22 tux > kernel: IP: [<ffffffffa0003789>] wmi_install_notify_handler+0x39/0x80 > [wmi] Dec 28 16:00:22 tux kernel: PGD 565f3067 PUD 0 Dec 28 16:00:22 tux > kernel: Oops: 0000 [#1] SMP Dec 28 16:00:22 tux kernel: last sysfs > file: /sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq Dec 28 > 16:00:22 tux kernel: CPU 1 Dec 28 16:00:22 tux kernel: Pid: 20215, comm: > modprobe Not tainted 2.6.33-rc2 #1 0T816J/Vostro 1520 Dec 28 16:00:22 tux > kernel: RIP: 0010:[<ffffffffa0003789>] [<ffffffffa0003789>] > wmi_install_notify_handler+0x39/0x80 [wmi] Dec 28 16:00:22 tux kernel: > RSP: 0018:ffff88009434bed8 EFLAGS: 00010202 Dec 28 16:00:22 tux kernel: > RAX: 0000000000000015 RBX: ffffffffa014f0f0 RCX: 000000000000009d Dec 28 > 16:00:22 tux kernel: RDX: 00000000fffffff4 RSI: ffff88009434be98 RDI: > ffff88009434be8c Dec 28 16:00:22 tux kernel: RBP: ffff88009434bef8 R08: > ffff88009434be88 R09: 0000000000000010 Dec 28 16:00:22 tux kernel: R10: > ffff88009434bee0 R11: 0000000000000006 R12: 0000000000000000 Dec 28 > 16:00:22 tux kernel: R13: 0000000002188470 R14: 0000000000000000 R15: > 0000000000000000 Dec 28 16:00:22 tux kernel: FS: 00007fb6aa7446f0(0000) > GS:ffff880028300000(0000) knlGS:0000000000000000 Dec 28 16:00:22 tux > kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b Dec 28 16:00:22 > tux kernel: CR2: 0000000100000024 CR3: 00000000bd319000 CR4: > 00000000000406e0 Dec 28 16:00:22 tux kernel: DR0: 0000000000000000 DR1: > 0000000000000000 DR2: 0000000000000000 Dec 28 16:00:22 tux kernel: DR3: > 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Dec 28 > 16:00:22 tux kernel: Process modprobe (pid: 20215, threadinfo > ffff88009434a000, task ffff8800a3a0ace0) Dec 28 16:00:22 tux kernel: > Stack: Dec 28 16:00:22 tux kernel: ffff88009434bef8 00000000fffffff4 > 0000000000000000 ffffffffa0152000 Dec 28 16:00:22 tux kernel: <0> > ffff88009434bf18 ffffffffa0152142 0000000000000000 0000000000000000 Dec > 28 16:00:22 tux kernel: <0> ffff88009434bf48 ffffffff810001d7 > 0000000000000000 ffffffffa014f780 Dec 28 16:00:22 tux kernel: Call Trace: > Dec 28 16:00:22 tux kernel: [<ffffffffa0152000>] ? > dell_wmi_init+0x0/0x14a [dell_wmi] Dec 28 16:00:22 tux kernel: > [<ffffffffa0152142>] dell_wmi_init+0x142/0x14a [dell_wmi] Dec 28 16:00:22 > tux kernel: [<ffffffff810001d7>] do_one_initcall+0x37/0x190 Dec 28 > 16:00:22 tux kernel: [<ffffffff81074408>] sys_init_module+0xd8/0x250 Dec > 28 16:00:22 tux kernel: [<ffffffff810024ab>] > system_call_fastpath+0x16/0x1b Dec 28 16:00:22 tux kernel: Code: 65 f8 48 > 89 f3 49 89 d4 48 85 f6 74 35 48 85 ff 74 30 48 8d 75 e8 e8 27 fd ff ff > 48 8b 55 e8 b8 06 00 00 00 48 85 d2 74 09 b0 15 <48> 83 7a 30 00 74 20 48 > 8b 5d f0 4c 8b 65 f8 c9 c3 66 0f 1f 44 Dec 28 16:00:22 tux kernel: RIP > [<ffffffffa0003789>] wmi_install_notify_handler+0x39/0x80 [wmi] Dec 28 > 16:00:22 tux kernel: RSP <ffff88009434bed8> Dec 28 16:00:22 tux kernel: > CR2: 0000000100000024 Dec 28 16:00:22 tux kernel: ---[ end trace > d18b623021a6c139 ]--- I've fixed this one by changing wmi.c : --- wmi.c 2009-12-28 17:11:52.000000000 +0100 +++ wmi.c.changed 2009-12-28 17:12:17.000000000 +0100 @@ -488,12 +488,13 @@ { struct wmi_block *block; acpi_status status; + bool err; if (!guid || !handler) return AE_BAD_PARAMETER; - find_guid(guid, &block); - if (!block) + err = find_guid(guid, &block); + if (!err) return AE_NOT_EXIST; if (block->handler) Signed-off-by: rol(a)as2917.net <Paul Rolland> but now I have : input: Dell WMI hotkeys as /devices/virtual/input/input13 dell-wmi: Unable to register notify handler - 6 sys_init_module: 'dell_wmi'->init suspiciously returned 6, it should follow 0/-E convention sys_init_module: loading module anyway... Pid: 2220, comm: modprobe Not tainted 2.6.33-rc2 #1 Call Trace: [<ffffffff8107450a>] sys_init_module+0x1da/0x250 [<ffffffff810024ab>] system_call_fastpath+0x16/0x1b Then, I tried to remove dell-wmi to fix the warning, and then I have : BUG: unable to handle kernel NULL pointer dereference at 00000000000008b0 IP: [<ffffffffa024971b>] wmi_remove_notify_handler+0x2b/0x60 [wmi] PGD bb506067 PUD bd170067 PMD 0 Oops: 0000 [#1] SMP last sysfs file: /sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq CPU 1 Pid: 3833, comm: rmmod Not tainted 2.6.33-rc2 #1 0T816J/Vostro 1520 RIP: 0010:[<ffffffffa024971b>] [<ffffffffa024971b>] wmi_remove_notify_handler+0x2b/0x60 [wmi] RSP: 0000:ffff8800bd3e7ea8 EFLAGS: 00010202 RAX: 000000000000000a RBX: 0000000000000880 RCX: 000000000000009d RDX: 0000000000000000 RSI: ffff8800bd3e7e68 RDI: 0000000000000880 RBP: ffff8800bd3e7eb8 R08: ffff8800bd3e7e58 R09: 0000000000000010 R10: ffff8800bd3e7eb0 R11: 0000000000000006 R12: ffffffffa0251780 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000001 FS: 00007f628c4c46f0(0000) GS:ffff880028300000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b CR2: 00000000000008b0 CR3: 00000000bb429000 CR4: 00000000000406e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Process rmmod (pid: 3833, threadinfo ffff8800bd3e6000, task ffff88013e43d9c0) Stack: ffff8800bd3e7ec8 0000000000000880 ffff8800bd3e7ec8 ffffffffa0251374 <0> ffff8800bd3e7f78 ffffffff81072091 ffff88010aa39040 ffff88013e43d9c0 <0> ffffffffa0251780 ffffffff00000880 ffff8800bd3e7f14 ffffffff81024461 Call Trace: [<ffffffffa0251374>] dell_wmi_exit+0x10/0x1e [dell_wmi] [<ffffffff81072091>] sys_delete_module+0x1b1/0x290 [<ffffffff81024461>] ? do_page_fault+0x131/0x2d0 [<ffffffff810024ab>] system_call_fastpath+0x16/0x1b Code: 55 b8 01 10 00 00 48 89 e5 48 83 ec 10 48 85 ff 74 3f 48 8d 75 f8 e8 95 fd ff ff 48 8b 7d f8 b8 06 00 00 00 48 85 ff 74 28 b0 0a <48> 83 7f 30 00 74 1f 31 f6 e8 37 ff ff ff 48 8b 55 f8 48 c7 42 RIP [<ffffffffa024971b>] wmi_remove_notify_handler+0x2b/0x60 [wmi] RSP <ffff8800bd3e7ea8> CR2: 00000000000008b0 ---[ end trace b8447e2a4bf54240 ]--- Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Paul Rolland on 28 Dec 2009 12:00 Hello, > Message from syslogd(a)tux at Dec 28 16:00:22 ... > kernel:CR2: 0000000100000024 > Dec 28 16:00:22 tux kernel: ACPI: WMI: Mapper loaded > Dec 28 16:00:22 tux kernel: input: Dell WMI hotkeys > as /devices/virtual/input/input13 Dec 28 16:00:22 tux kernel: BUG: unable > to handle kernel paging request at 0000000100000024 Dec 28 16:00:22 tux > kernel: IP: [<ffffffffa0003789>] wmi_install_notify_handler+0x39/0x80 > [wmi] Dec 28 16:00:22 tux kernel: PGD 565f3067 PUD 0 Dec 28 16:00:22 tux > kernel: Oops: 0000 [#1] SMP Dec 28 16:00:22 tux kernel: last sysfs > file: /sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq Dec 28 > 16:00:22 tux kernel: CPU 1 Dec 28 16:00:22 tux kernel: Pid: 20215, comm: > modprobe Not tainted 2.6.33-rc2 #1 0T816J/Vostro 1520 Dec 28 16:00:22 tux > kernel: RIP: 0010:[<ffffffffa0003789>] [<ffffffffa0003789>] > wmi_install_notify_handler+0x39/0x80 [wmi] Dec 28 16:00:22 tux kernel: > RSP: 0018:ffff88009434bed8 EFLAGS: 00010202 Dec 28 16:00:22 tux kernel: > RAX: 0000000000000015 RBX: ffffffffa014f0f0 RCX: 000000000000009d Dec 28 > 16:00:22 tux kernel: RDX: 00000000fffffff4 RSI: ffff88009434be98 RDI: > ffff88009434be8c Dec 28 16:00:22 tux kernel: RBP: ffff88009434bef8 R08: > ffff88009434be88 R09: 0000000000000010 Dec 28 16:00:22 tux kernel: R10: > ffff88009434bee0 R11: 0000000000000006 R12: 0000000000000000 Dec 28 > 16:00:22 tux kernel: R13: 0000000002188470 R14: 0000000000000000 R15: > 0000000000000000 Dec 28 16:00:22 tux kernel: FS: 00007fb6aa7446f0(0000) > GS:ffff880028300000(0000) knlGS:0000000000000000 Dec 28 16:00:22 tux > kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b Dec 28 16:00:22 > tux kernel: CR2: 0000000100000024 CR3: 00000000bd319000 CR4: > 00000000000406e0 Dec 28 16:00:22 tux kernel: DR0: 0000000000000000 DR1: > 0000000000000000 DR2: 0000000000000000 Dec 28 16:00:22 tux kernel: DR3: > 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Dec 28 > 16:00:22 tux kernel: Process modprobe (pid: 20215, threadinfo > ffff88009434a000, task ffff8800a3a0ace0) Dec 28 16:00:22 tux kernel: > Stack: Dec 28 16:00:22 tux kernel: ffff88009434bef8 00000000fffffff4 > 0000000000000000 ffffffffa0152000 Dec 28 16:00:22 tux kernel: <0> > ffff88009434bf18 ffffffffa0152142 0000000000000000 0000000000000000 Dec > 28 16:00:22 tux kernel: <0> ffff88009434bf48 ffffffff810001d7 > 0000000000000000 ffffffffa014f780 Dec 28 16:00:22 tux kernel: Call Trace: > Dec 28 16:00:22 tux kernel: [<ffffffffa0152000>] ? > dell_wmi_init+0x0/0x14a [dell_wmi] Dec 28 16:00:22 tux kernel: > [<ffffffffa0152142>] dell_wmi_init+0x142/0x14a [dell_wmi] Dec 28 16:00:22 > tux kernel: [<ffffffff810001d7>] do_one_initcall+0x37/0x190 Dec 28 > 16:00:22 tux kernel: [<ffffffff81074408>] sys_init_module+0xd8/0x250 Dec > 28 16:00:22 tux kernel: [<ffffffff810024ab>] > system_call_fastpath+0x16/0x1b Dec 28 16:00:22 tux kernel: Code: 65 f8 48 > 89 f3 49 89 d4 48 85 f6 74 35 48 85 ff 74 30 48 8d 75 e8 e8 27 fd ff ff > 48 8b 55 e8 b8 06 00 00 00 48 85 d2 74 09 b0 15 <48> 83 7a 30 00 74 20 48 > 8b 5d f0 4c 8b 65 f8 c9 c3 66 0f 1f 44 Dec 28 16:00:22 tux kernel: RIP > [<ffffffffa0003789>] wmi_install_notify_handler+0x39/0x80 [wmi] Dec 28 > 16:00:22 tux kernel: RSP <ffff88009434bed8> Dec 28 16:00:22 tux kernel: > CR2: 0000000100000024 Dec 28 16:00:22 tux kernel: ---[ end trace > d18b623021a6c139 ]--- > Fixed this completely with the following two patches on top of 2.6.33-rc2 : --- wmi.c.orig 2009-12-28 17:27:15.000000000 +0100 +++ wmi.c 2009-12-28 17:39:01.000000000 +0100 @@ -488,12 +488,13 @@ { struct wmi_block *block; acpi_status status; + bool err; if (!guid || !handler) return AE_BAD_PARAMETER; - find_guid(guid, &block); - if (!block) + err = find_guid(guid, &block); + if (!err) return AE_NOT_EXIST; if (block->handler) @@ -517,12 +518,13 @@ { struct wmi_block *block; acpi_status status; + bool err; if (!guid) return AE_BAD_PARAMETER; - find_guid(guid, &block); - if (!block) + err = find_guid(guid, &block); + if (!err) return AE_NOT_EXIST; if (!block->handler) --- dell-wmi.c.orig 2009-12-28 17:49:09.000000000 +0100 +++ dell-wmi.c 2009-12-28 17:41:36.000000000 +0100 @@ -343,7 +343,7 @@ printk(KERN_ERR "dell-wmi: Unable to register notify handler - %d\n", err); - return err; + return -err; } return 0; Signed-off-by: rol(a)as2917.net <Paul Rolland> Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Dmitry Torokhov on 28 Dec 2009 15:20 Hi Paul, On Mon, Dec 28, 2009 at 05:53:01PM +0100, Paul Rolland wrote: > > Fixed this completely with the following two patches on top of 2.6.33-rc2 : > > --- wmi.c.orig 2009-12-28 17:27:15.000000000 +0100 > +++ wmi.c 2009-12-28 17:39:01.000000000 +0100 > @@ -488,12 +488,13 @@ > { > struct wmi_block *block; > acpi_status status; > + bool err; > > if (!guid || !handler) > return AE_BAD_PARAMETER; > > - find_guid(guid, &block); > - if (!block) > + err = find_guid(guid, &block); > + if (!err) > return AE_NOT_EXIST; > > if (block->handler) > @@ -517,12 +518,13 @@ > { > struct wmi_block *block; > acpi_status status; > + bool err; > > if (!guid) > return AE_BAD_PARAMETER; > > - find_guid(guid, &block); > - if (!block) > + err = find_guid(guid, &block); > + if (!err) > return AE_NOT_EXIST; > > if (!block->handler) > > --- dell-wmi.c.orig 2009-12-28 17:49:09.000000000 +0100 > +++ dell-wmi.c 2009-12-28 17:41:36.000000000 +0100 > @@ -343,7 +343,7 @@ > printk(KERN_ERR > "dell-wmi: Unable to register notify handler - %d\n", > err); > - return err; > + return -err; This still leaks AE_* error codes to the upper layers which do not care for them and expect the errors from Exxxx namespace. I wonder why wmi is not using standard error codes but instead decided to come up with it's own. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Len Brown on 30 Dec 2009 01:20 Thanks for the quick test/debug Paul, > Fixed this completely with the following two patches on top of 2.6.33-rc2 : > > --- wmi.c.orig 2009-12-28 17:27:15.000000000 +0100 > +++ wmi.c 2009-12-28 17:39:01.000000000 +0100 > @@ -488,12 +488,13 @@ > { > struct wmi_block *block; > acpi_status status; > + bool err; > > if (!guid || !handler) > return AE_BAD_PARAMETER; > > - find_guid(guid, &block); > - if (!block) > + err = find_guid(guid, &block); > + if (!err) Unfortunately, find_guid() returns 1 for success and 0 for failure, making this code look backwards. I've applied this, but changed it to if (!find_guid()) to be consistent with the other callers. > return AE_NOT_EXIST; > > if (block->handler) > @@ -517,12 +518,13 @@ > { > struct wmi_block *block; > acpi_status status; > + bool err; > > if (!guid) > return AE_BAD_PARAMETER; > > - find_guid(guid, &block); > - if (!block) > + err = find_guid(guid, &block); > + if (!err) > return AE_NOT_EXIST; > > if (!block->handler) > > --- dell-wmi.c.orig 2009-12-28 17:49:09.000000000 +0100 > +++ dell-wmi.c 2009-12-28 17:41:36.000000000 +0100 > @@ -343,7 +343,7 @@ > printk(KERN_ERR > "dell-wmi: Unable to register notify handler - %d\n", > err); > - return err; > + return -err; This change is not quite correct, but the correct fix is already in the acpi-test tree in the patch "dell-wmi: sys_init_module: 'dell_wmi'->init suspiciously returned 21, it should follow 0/-E convention" I'll reply with both of the patches in a sec. Please let me know if they are sufficient to fix your system. thanks, -Len Brown, Intel Open Source Technology Center > } > > return 0; > > > Signed-off-by: rol(a)as2917.net <Paul Rolland> > > Paul > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Paul Rolland on 30 Dec 2009 02:20
Hi Len, On Wed, 30 Dec 2009 01:14:48 -0500 (EST) Len Brown <lenb(a)kernel.org> wrote: > Thanks for the quick test/debug Paul, > > > Fixed this completely with the following two patches on top of > > 2.6.33-rc2 : > > > > --- wmi.c.orig 2009-12-28 17:27:15.000000000 +0100 > > +++ wmi.c 2009-12-28 17:39:01.000000000 +0100 > > @@ -488,12 +488,13 @@ > > { > > struct wmi_block *block; > > acpi_status status; > > + bool err; > > > > if (!guid || !handler) > > return AE_BAD_PARAMETER; > > > > - find_guid(guid, &block); > > - if (!block) > > + err = find_guid(guid, &block); > > + if (!err) > > Unfortunately, find_guid() returns 1 for success > and 0 for failure, making this code look backwards. > > I've applied this, but changed it to if (!find_guid()) > to be consistent with the other callers. That's ok, thanks for reviewing ! > > --- dell-wmi.c.orig 2009-12-28 17:49:09.000000000 +0100 > > +++ dell-wmi.c 2009-12-28 17:41:36.000000000 +0100 > > @@ -343,7 +343,7 @@ > > printk(KERN_ERR > > "dell-wmi: Unable to register notify handler - > > %d\n", err); > > - return err; > > + return -err; > > This change is not quite correct, > but the correct fix is already in the acpi-test tree in the patch > "dell-wmi: sys_init_module: 'dell_wmi'->init suspiciously returned 21, > it should follow 0/-E convention" Yes, Dmitry sent a mail indicating that yesterday. I must admit I've been too fast with that part of my fix ,( > I'll reply with both of the patches in a sec. > Please let me know if they are sufficient to fix your system. They are. You can add a : Tested-by: Paul Rolland <rol(a)as2917.net> for what it matters ;) Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |