Prev: [PATCH] Fix infinite loop in get_futex_key when backed by huge pages
Next: Staging: comedi: fix EXPORT_SYMBOL(FOO) coding style issues in ni_labpc.c
From: John Kacur on 19 Apr 2010 16:10


On Mon, 19 Apr 2010, Steven Rostedt wrote:

> On Mon, 2010-04-19 at 20:11 +0200, John Kacur wrote:
> >
> > On Mon, 19 Apr 2010, Randy Dunlap wrote:
> >
> > > From: Randy Dunlap <randy.dunlap(a)oracle.com>
> > >
> > > Update Makefile to support rpmbuild DESTDIR usage.
> >
> > So, what would happen if you did
> > make DESTDIR=/usr/local install ?
> >
> > I think you would get /usr/local/usr/local
> > So, I think I would NAK this patch.
> >
> > I also don't believe there is anything magical about DESTDIR in a spec
> > file. Essentially, prefix in this makefile is equivalent to DESTDIR, so
> > you can replace DESTDIR with prefix in a spec template.
> >
>
> NAK is too strong. I was looking at what perf does, and it basically
> makes prefix and DESTDIR the same.
>
> ifndef DESTDIR
> prefix = $(HOME)
> endif
>
> We could do..
>
> ifndef DESDIR
> prefix = /usr/local/bin
> endif
>
> and then, if DESTDIR is not set, it would do the right thing.
>

Yeah, the above is actually an unsatisfactory workaround.
see 7ae5f21361fea11f58c398701da635f778635d13

Another solution is to not copy obfuscated Makefiles when starting new
projects!
/me runs away
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Randy Dunlap on 19 Apr 2010 16:20
On 04/19/10 13:06, John Kacur wrote:
>
> Yeah, the above is actually an unsatisfactory workaround.
> see 7ae5f21361fea11f58c398701da635f778635d13
>
> Another solution is to not copy obfuscated Makefiles when starting new
> projects!

Very much agreed.

> /me runs away


--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
First  |  Prev  | 
Pages: 1 2
Prev: [PATCH] Fix infinite loop in get_futex_key when backed by huge pages
Next: Staging: comedi: fix EXPORT_SYMBOL(FOO) coding style issues in ni_labpc.c