From: Bruce Momjian on
Bruce Momjian wrote:
> Simon Riggs wrote:
> > On Sat, 2010-03-13 at 11:26 -0800, Josh Berkus wrote:
> > > > The list has been reduced greatly in the past week. What about HS/SR
> > > > open items?
> > >
> > > I'd like to see vacuum_defer_cleanup_age added to the "Archive" section
> > > of postgresql.conf,
> >
> > Not all parameters are in postgresql.conf.sample. Encouraging people to
> > do this is the wrong approach.
> >
> > > and add it to the docs (I'll write something this
> > > week).
> >
> > It's already in the docs, so if they read it and understand it they can
> > add it to the postgresql.conf if they so choose.
>
> I agree with Josh Berkus that vacuum_defer_cleanup_age should be in
> postgresql.conf. We don't stop listing items just because they are
> dangerous, e.g. fsync, or to discourage their use. I believe Greg Smith
> also felt it should be included.

The bottom line is that the fact that vacuum_defer_cleanup_age is
missing from postgresql.conf is causing confusion because none of the
other settings are skipped to discourage their use. If you want to
apply that policy, we would have to revisit all the postgresql.conf
settings, and I don't think there is much interest in doing that.

--
Bruce Momjian <bruce(a)momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Robert Haas on
On Wed, Mar 17, 2010 at 11:42 PM, Bruce Momjian <bruce(a)momjian.us> wrote:
> Bruce Momjian wrote:
>> Simon Riggs wrote:
>> > On Sat, 2010-03-13 at 11:26 -0800, Josh Berkus wrote:
>> > > > The list has been reduced greatly in the past week.  What about HS/SR
>> > > > open items?
>> > >
>> > > I'd like to see vacuum_defer_cleanup_age added to the "Archive" section
>> > > of postgresql.conf,
>> >
>> > Not all parameters are in postgresql.conf.sample. Encouraging people to
>> > do this is the wrong approach.
>> >
>> > >  and add it to the docs (I'll write something this
>> > > week).
>> >
>> > It's already in the docs, so if they read it and understand it they can
>> > add it to the postgresql.conf if they so choose.
>>
>> I agree with Josh Berkus that vacuum_defer_cleanup_age should be in
>> postgresql.conf.  We don't stop listing items just because they are
>> dangerous, e.g. fsync, or to discourage their use.  I believe Greg Smith
>> also felt it should be included.
>
> The bottom line is that the fact that vacuum_defer_cleanup_age is
> missing from postgresql.conf is causing confusion because none of the
> other settings are skipped to discourage their use.  If you want to
> apply that policy, we would have to revisit all the postgresql.conf
> settings, and I don't think there is much interest in doing that.

I agree. If we're going to have the option, it should be in the file.

....Robert

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Simon Riggs on
On Wed, 2010-03-17 at 23:29 -0400, Bruce Momjian wrote:
> Simon Riggs wrote:
> > On Sat, 2010-03-13 at 11:26 -0800, Josh Berkus wrote:
> > > > The list has been reduced greatly in the past week. What about HS/SR
> > > > open items?
> > >
> > > I'd like to see vacuum_defer_cleanup_age added to the "Archive" section
> > > of postgresql.conf,
> >
> > Not all parameters are in postgresql.conf.sample. Encouraging people to
> > do this is the wrong approach.
> >

> I agree with Josh Berkus that vacuum_defer_cleanup_age should be in
> postgresql.conf. We don't stop listing items just because they are
> dangerous, e.g. fsync, or to discourage their use. I believe Greg Smith
> also felt it should be included.

Added to postgresql.conf.sample

--
Simon Riggs www.2ndQuadrant.com


--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Josh Berkus on

>> It's already in the docs, so if they read it and understand it they can
>> add it to the postgresql.conf if they so choose.
>
> I agree with Josh Berkus that vacuum_defer_cleanup_age should be in
> postgresql.conf. We don't stop listing items just because they are
> dangerous, e.g. fsync, or to discourage their use. I believe Greg Smith
> also felt it should be included.

Or, let's put it another way: I've made my opinion clear in the past
that I think that we ought to ship with a minimal postgresql.conf with
maybe 15 items in it. If we are going to continue to ship with
postgresql.conf "kitchen sick" version, however, it should include
vacuum_defer_cleanup_age.

--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: "Joshua D. Drake" on
On Thu, 2010-03-18 at 10:18 -0700, Josh Berkus wrote:
> >> It's already in the docs, so if they read it and understand it they can
> >> add it to the postgresql.conf if they so choose.
> >
> > I agree with Josh Berkus that vacuum_defer_cleanup_age should be in
> > postgresql.conf. We don't stop listing items just because they are
> > dangerous, e.g. fsync, or to discourage their use. I believe Greg Smith
> > also felt it should be included.
>
> Or, let's put it another way: I've made my opinion clear in the past
> that I think that we ought to ship with a minimal postgresql.conf with
> maybe 15 items in it. If we are going to continue to ship with
> postgresql.conf "kitchen sick" version, however, it should include
> vacuum_defer_cleanup_age.

+1

As usual, the postgresql.conf is entirely too full. We should ship with
the top 15. If this gains any traction, I am sure that Greg Smith,
Berkus and I could provide that list with nothing but a care bear
discussion.

Joshua D. Drake

>
> --
> -- Josh Berkus
> PostgreSQL Experts Inc.
> http://www.pgexperts.com
>


--
PostgreSQL.org Major Contributor
Command Prompt, Inc: http://www.commandprompt.com/ - 503.667.4564
Consulting, Training, Support, Custom Development, Engineering
Respect is earned, not gained through arbitrary and repetitive use or Mr. or Sir.


--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers