NaN/Inf fix for ECPG
in [PgSql]
|
Prev: pgsql: Clean up package namespace use and use ofSafe in plperl.
Next: ToDo: plpgsql plugin for query and expression verification
From: Tom Lane on 25 Feb 2010 10:37 Boszormenyi Zoltan <zb(a)cybertec.at> writes: > Can you try whether the first patch (missing float.h from data.c) > solves the problem? And together with the 2nd one? In that > patch I fixed the order of float.h and math.h in nan_test.pgc, > which is the opposite of the order found in e.g. backend/utils/adt/float.c. > The 3rd patch is explicit about NetBSD/mips but it doesn't feel right. The third patch is surely wrong. We don't need to do that in the backend's instance of get_float8_nan, so ecpglib shouldn't need it either. I suspect that the ultimate cause of this is either one of the header inclusion inconsistencies you found, or something associated with not pulling in all the stuff that postgres.h does. port/netbsd.h is empty though, so it's not immediately clear what might be missing. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Boszormenyi Zoltan on 26 Feb 2010 06:12 Tom Lane �rta: > Boszormenyi Zoltan <zb(a)cybertec.at> writes: > >> Can you try whether the first patch (missing float.h from data.c) >> solves the problem? And together with the 2nd one? In that >> patch I fixed the order of float.h and math.h in nan_test.pgc, >> which is the opposite of the order found in e.g. backend/utils/adt/float.c. >> > > >> The 3rd patch is explicit about NetBSD/mips but it doesn't feel right. >> > > The third patch is surely wrong. We don't need to do that in the > backend's instance of get_float8_nan, so ecpglib shouldn't need it > either. > > I suspect that the ultimate cause of this is either one of the header > inclusion inconsistencies you found, or something associated with > not pulling in all the stuff that postgres.h does. port/netbsd.h > is empty though, so it's not immediately clear what might be missing. > ecpglib/data.c includes "postgres_fe.h", so it should be pulling everything that's relevant from port/*, right? Michael, can we try to install the first two patches? They wouldn't hurt. Thanks in advance, Zolt�n B�sz�rm�nyi -- Bible has answers for everything. Proof: "But let your communication be, Yea, yea; Nay, nay: for whatsoever is more than these cometh of evil." (Matthew 5:37) - basics of digital technology. "May your kingdom come" - superficial description of plate tectonics ---------------------------------- Zolt�n B�sz�rm�nyi Cybertec Sch�nig & Sch�nig GmbH http://www.postgresql.at/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: =?iso-8859-1?Q?R=E9mi_Zara?= on 26 Feb 2010 07:47 Le 26 févr. 2010 à 12:12, Boszormenyi Zoltan a écrit : > > ecpglib/data.c includes "postgres_fe.h", so it should be pulling > everything that's relevant from port/*, right? > > Michael, can we try to install the first two patches? > They wouldn't hurt. > I've tried patch 1 and 2, but they do not work. The fact is that the code is not used in the backend, because strtod("NaN", endptr) works. (isnan(strtod("NaN", endptr)) is true). I should also note that isnan((double)nan("")) is true (works). I will also report to NetBSD that isnan((double)NAN) does not work on mips. Regards, Rémi Zara -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Michael Meskes on 26 Feb 2010 08:46 On Fri, Feb 26, 2010 at 12:12:10PM +0100, Boszormenyi Zoltan wrote: > Michael, can we try to install the first two patches? If I understood the rest of the thread correctly this is not needed anymore, right? Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org ICQ 179140304, AIM/Yahoo/Skype michaelmeskes, Jabber meskes(a)jabber.org VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Tom Lane on 26 Feb 2010 11:11
=?iso-8859-1?Q?R=E9mi_Zara?= <remi_zara(a)mac.com> writes: > I've tried patch 1 and 2, but they do not work. The fact is that the code is not used in the backend, because strtod("NaN", endptr) works. (isnan(strtod("NaN", endptr)) is true). Hmm. So what do you get from SELECT 'nan'::numeric::float8; on that machine? That should exercise the backend's version of get_float8_nan(). regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |