NaN/Inf fix for ECPG
in [PgSql]
|
Prev: pgsql: Clean up package namespace use and use ofSafe in plperl.
Next: ToDo: plpgsql plugin for query and expression verification
From: Boszormenyi Zoltan on 16 Feb 2010 06:16 Hi, buildfarm member "pika" fails the NaN test. Does FreeBSD/MIPS really return true for isinf(NaN)? Anyway, the attached patch tries to fix the test case by testing isnan() first and doesn't check isinf() if isnan() returned true. Best regards, Zoltán Böszörményi -- Bible has answers for everything. Proof: "But let your communication be, Yea, yea; Nay, nay: for whatsoever is more than these cometh of evil." (Matthew 5:37) - basics of digital technology. "May your kingdom come" - superficial description of plate tectonics ---------------------------------- Zoltán Böszörményi Cybertec Schönig & Schönig GmbH http://www.postgresql.at/
From: Boszormenyi Zoltan on 16 Feb 2010 06:21 Boszormenyi Zoltan írta: > Hi, > > buildfarm member "pika" fails the NaN test. > Does FreeBSD/MIPS really return true for isinf(NaN)? > Anyway, the attached patch tries to fix the test case > by testing isnan() first and doesn't check isinf() > if isnan() returned true. > I lied in the patch name, it wasn't a context diff. Also, the same remedy seems to be needed in ecpglib/execute.c, too. Best regards, Zoltán Böszörményi -- Bible has answers for everything. Proof: "But let your communication be, Yea, yea; Nay, nay: for whatsoever is more than these cometh of evil." (Matthew 5:37) - basics of digital technology. "May your kingdom come" - superficial description of plate tectonics ---------------------------------- Zoltán Böszörményi Cybertec Schönig & Schönig GmbH http://www.postgresql.at/
From: Michael Meskes on 17 Feb 2010 02:50 On Tue, Feb 16, 2010 at 10:28:00PM +0100, Michael Meskes wrote: > I was trying to stress the *beta* status. Maybe someone into NetBSD might be > interested in reporting this as a bug. At least it behaves different to all > other archs we have. Hmm, it seems the patch didn't work. Back to the drawing board. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org ICQ 179140304, AIM/Yahoo/Skype michaelmeskes, Jabber meskes(a)jabber.org VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Michael Meskes on 16 Feb 2010 13:41 On Tue, Feb 16, 2010 at 12:21:34PM +0100, Boszormenyi Zoltan wrote: > > Does FreeBSD/MIPS really return true for isinf(NaN)? Actually it's a netbsd beta version, so maybe there's a bug in their libc. But anyway, the patch doesn't seem to hurt, so I committed it. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org ICQ 179140304, AIM/Yahoo/Skype michaelmeskes, Jabber meskes(a)jabber.org VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Boszormenyi Zoltan on 16 Feb 2010 14:01
Michael Meskes írta: > On Tue, Feb 16, 2010 at 12:21:34PM +0100, Boszormenyi Zoltan wrote: > >>> Does FreeBSD/MIPS really return true for isinf(NaN)? >>> > > Actually it's a netbsd beta version, so maybe there's a bug in their libc. > I realized my typo after sending my mail. Sorry if I offended anyone calling NetBSD FreeBSD. :-) > But anyway, the patch doesn't seem to hurt, so I committed it. > Thanks. Best regards, Zoltán Böszörményi -- Bible has answers for everything. Proof: "But let your communication be, Yea, yea; Nay, nay: for whatsoever is more than these cometh of evil." (Matthew 5:37) - basics of digital technology. "May your kingdom come" - superficial description of plate tectonics ---------------------------------- Zoltán Böszörményi Cybertec Schönig & Schönig GmbH http://www.postgresql.at/ -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |