Prev: [HACKERS] PostGIS vs. PGXS in 9.0beta3
Next: [HACKERS] do we need to postpone beta4?
From: Andrew Dunstan on 28 Jul 2010 07:10


Mark Cave-Ayland wrote:
> Andrew Dunstan wrote:
>
>> The real problem has nothing to do with any of the analysis, as you
>> say. It is this: they have an override file for PGXS and it uses
>> $(mkinstalldirs) which we got rid of about a year ago. So apparently
>> they haven't been testing much against any of our alphas or betas or
>> they would have seen this long ago. The correct fix is to do the
>> following in the PostGIS source root:
>>
>> sed -i -e 's/mkinstalldirs/MKDIR_P/' postgis/Makefile.pgxs
>>
>> cheers
>>
>> andrew
>
> Hmmm that's totally wrong - the override in Makefile.pgxs should only
> ever be loaded for PostgreSQL 8.3 and 8.4, and not PostgreSQL 9.0
> since it already has the correct installation paths.
>
> What I suspect is that you're actually getting bitten by this:
>
> http://markmail.org/message/k7iolbazhrqhijfk#query:pg_config%20jun%202007+page:1+mid:rqk6ux2e7npqbrzf+state:results
>
>
> Or, in other words, configure is picking up the wrong pg_config. Since
> the path fix in the thread was not backported to < 8.3, then the
> presence of an another pg_config for PostgreSQL < 8.3 in PATH will
> break things :(

No, the configure test is wrong. Here's what's in configure.ac:


dnl Temporary hack until minimum PostgreSQL version is 8.5:
dnl If PostgreSQL < 8.5 is detected, trigger the inclusion of the
new versioned PGXS targets
PGXSOVERRIDE=0
if test ! "$PGSQL_MINOR_VERSION" -ge 5; then
PGXSOVERRIDE=1
fi


Of course, we don't have any such thing as 8.5.

cheers

andrew






--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Mark Cave-Ayland on 28 Jul 2010 07:22
Andrew Dunstan wrote:

> No, the configure test is wrong. Here's what's in configure.ac:
>
>
> dnl Temporary hack until minimum PostgreSQL version is 8.5:
> dnl If PostgreSQL < 8.5 is detected, trigger the inclusion of the
> new versioned PGXS targets
> PGXSOVERRIDE=0
> if test ! "$PGSQL_MINOR_VERSION" -ge 5; then
> PGXSOVERRIDE=1
> fi
>
>
> Of course, we don't have any such thing as 8.5.

Ah wait - I see. The fix is in already in the 1.5 branch, it just hasn't
hit a release yet :(

http://trac.osgeo.org/postgis/changeset/5421/branches/1.5/configure.ac

Looks like we need to push a new release in time for 9.0...


ATB,

Mark.

--
Mark Cave-Ayland - Senior Technical Architect
PostgreSQL - PostGIS
Sirius Corporation plc - control through freedom
http://www.siriusit.co.uk
t: +44 870 608 0063

Sirius Labs: http://www.siriusit.co.uk/labs

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

First  |  Prev  | 
Pages: 1 2
Prev: [HACKERS] PostGIS vs. PGXS in 9.0beta3
Next: [HACKERS] do we need to postpone beta4?