PostGIS vs. PGXS in 9.0beta3
in [PgSql]
|
From: Robert Haas on 27 Jul 2010 13:39 On Tue, Jul 27, 2010 at 1:13 PM, Josh Berkus <josh(a)agliodbs.com> wrote: > http://postgis.refractions.net/pipermail/postgis-users/2010-May/026654.html It's not obvious that there's an unresolved issue here; downthread there's some indication this might be an environment problem? http://postgis.refractions.net/pipermail/postgis-users/2010-May/026658.html -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Andrew Dunstan on 27 Jul 2010 14:36 Robert Haas wrote: > On Tue, Jul 27, 2010 at 1:13 PM, Josh Berkus <josh(a)agliodbs.com> wrote: > >> http://postgis.refractions.net/pipermail/postgis-users/2010-May/026654.html >> > > It's not obvious that there's an unresolved issue here; downthread > there's some indication this might be an environment problem? > > http://postgis.refractions.net/pipermail/postgis-users/2010-May/026658.html > > No, I have just reproduced this with a totally vanilla environment. I think PostGIS probably needs to patch their makefile(s). cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Tom Lane on 27 Jul 2010 18:28 Josh Berkus <josh(a)agliodbs.com> writes: > A 9.0b3 tester reported this issue with our single most popular > PostgreSQL extension, PostGIS: > ================== > Postgis makes use of 'PGXS' in postgresql > 8.2. Within postgresql-9, > datadir and many other variables are defined as multiple values with an > append operator, like this: > $ grep -i datadir /usr/pgsql-9.0/lib/pgxs/src/Makefile.global > [snip] > datadir := /usr/pgsql-9.0/share This analysis is nonsense on its face --- := is not an append operator and we do not have any multiple values for datadir. The referenced postgis-users thread seems to indicate that the postgis guys found and fixed a problem in their own makefiles. If not, we need a clearer description of what they think the problem is. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Andrew Dunstan on 28 Jul 2010 00:41 Tom Lane wrote: > Josh Berkus <josh(a)agliodbs.com> writes: > >> A 9.0b3 tester reported this issue with our single most popular >> PostgreSQL extension, PostGIS: >> > > >> ================== >> Postgis makes use of 'PGXS' in postgresql > 8.2. Within postgresql-9, >> datadir and many other variables are defined as multiple values with an >> append operator, like this: >> > > >> $ grep -i datadir /usr/pgsql-9.0/lib/pgxs/src/Makefile.global >> [snip] >> datadir := /usr/pgsql-9.0/share >> > > This analysis is nonsense on its face --- := is not an append operator > and we do not have any multiple values for datadir. > > The referenced postgis-users thread seems to indicate that the postgis > guys found and fixed a problem in their own makefiles. If not, we need > a clearer description of what they think the problem is. > The real problem has nothing to do with any of the analysis, as you say. It is this: they have an override file for PGXS and it uses $(mkinstalldirs) which we got rid of about a year ago. So apparently they haven't been testing much against any of our alphas or betas or they would have seen this long ago. The correct fix is to do the following in the PostGIS source root: sed -i -e 's/mkinstalldirs/MKDIR_P/' postgis/Makefile.pgxs cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Mark Cave-Ayland on 28 Jul 2010 06:29 Andrew Dunstan wrote: > The real problem has nothing to do with any of the analysis, as you say. > It is this: they have an override file for PGXS and it uses > $(mkinstalldirs) which we got rid of about a year ago. So apparently > they haven't been testing much against any of our alphas or betas or > they would have seen this long ago. The correct fix is to do the > following in the PostGIS source root: > > sed -i -e 's/mkinstalldirs/MKDIR_P/' postgis/Makefile.pgxs > > cheers > > andrew Hmmm that's totally wrong - the override in Makefile.pgxs should only ever be loaded for PostgreSQL 8.3 and 8.4, and not PostgreSQL 9.0 since it already has the correct installation paths. What I suspect is that you're actually getting bitten by this: http://markmail.org/message/k7iolbazhrqhijfk#query:pg_config%20jun%202007+page:1+mid:rqk6ux2e7npqbrzf+state:results Or, in other words, configure is picking up the wrong pg_config. Since the path fix in the thread was not backported to < 8.3, then the presence of an another pg_config for PostgreSQL < 8.3 in PATH will break things :( ATB, Mark. -- Mark Cave-Ayland - Senior Technical Architect PostgreSQL - PostGIS Sirius Corporation plc - control through freedom http://www.siriusit.co.uk t: +44 870 608 0063 Sirius Labs: http://www.siriusit.co.uk/labs -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
|
Next
|
Last
Pages: 1 2 Prev: [HACKERS] PostGIS vs. PGXS in 9.0beta3 Next: [HACKERS] do we need to postpone beta4? |