SproutCore--over 20000 lines of new code!
in [JavaScript]
|
From: David Mark on 1 Jan 2010 02:19 On Jan 1, 2:07 am, Garrett Smith <dhtmlkitc...(a)gmail.com> wrote: [...] > > Sounds like Dojo. This library is not going to die. Is or isn't? It is a shame that so many people have worked for so long to produce something like this. I don't wish failure on anybody, but some people refuse to be helped (see the predicted Real World comment from the "creator" of this thing).
From: Garrett Smith on 1 Jan 2010 02:22 Charles Jolley wrote: > Hi I am the creator of sproutcore. If you had taken the time to look at the rest of sproutcore you might have noticed that corequery is not used very often because our view layer has a more powerful system called the rendercontext. > This message is not wrapping so well. What newsreader are you using? > Also I think nitpicking little bits of code like this is really pointless. Anyone who has written a big project knows that some parts receive more attention then others based on their actual real world needs. Picking one remote part like this and disecting it misses all to useful stuff you might have found if you has just looked. > That would seem like nitpicking if the point was not quality code. The code in Sproutcore that was just displayed has problems. Browser detection is known to be the source of forwards compibility issues. Basing a library on faulty inferences at the base level in the dependency chain is a disastrous decision. Such inferences and thinking for detecting styleFloat show another poor inference. None of that would pass code review. You probably don't want to hear that and have probably spent a good amount of time on it, but it is the truth. > For example spend some time looking at the datastore or observer layers If you would like to prepare for a code review, then this is a fine place. I recommend formatting the code to 72 chars. you should prepare to explain briefly the intent of the code (use diagrams if you like). Posters of this newsgroup will find the errors and mistakes in it for you. I can also meet you in person, as you're local. > > --- > frmsrcurl: http://compgroups.net/comp.lang.javascript/SproutCore-over-20000-lines-of-new-code Ah, using a web forum. Try downloading Thunderbird an getting an account with a newsgroup provider. I use eternal-september.org. THe newsgroup is comp.lang.javascript. -- Garrett comp.lang.javascript FAQ: http://jibbering.com/faq/
From: Andrew Poulos on 1 Jan 2010 04:36 On 1/01/2010 4:47 PM, Charles Jolley wrote: > Hi I am the creator of sproutcore. If you had taken the time to look at the rest of sproutcore you might have noticed that corequery is not used very often because our view layer has a more powerful system called the rendercontext. > > Also I think nitpicking little bits of code like this is really pointless. Anyone who has written a big project knows that some parts receive more attention then others based on their actual real world needs. Isn't the adage "Look after the pennies and the pounds look after themselves". Or, if you prefer, "God is in the detail". Andrew Poulos
From: Thomas 'PointedEars' Lahn on 1 Jan 2010 10:12 David Mark wrote: > Charles Jolley wrote: >> Hi I am the creator of sproutcore. If you had taken the time to look at >> the rest of sproutcore you might have noticed that corequery is not used >> very often because our view layer has a more powerful system called the >> rendercontext. > > [snipped 400+ lines of garbage] You have been told before that your code reviews are next to unreadable, thus next to useless. You have also been asked before to take more care when posting them. Suggestions have been made how this could be accomplished. Please do everyone a favor and, as your New Year's resolution, do not waste more bandwidth like this again. Thanks in advance. PointedEars -- realism: HTML 4.01 Strict evangelism: XHTML 1.0 Strict madness: XHTML 1.1 as application/xhtml+xml -- Bjoern Hoehrmann
From: David Mark on 1 Jan 2010 17:02
On Jan 1, 10:12 am, Thomas 'PointedEars' Lahn <PointedE...(a)web.de> wrote: > David Mark wrote: > > Charles Jolley wrote: > >> Hi I am the creator of sproutcore. If you had taken the time to look at > >> the rest of sproutcore you might have noticed that corequery is not used > >> very often because our view layer has a more powerful system called the > >> rendercontext. > > > [snipped 400+ lines of garbage] > > You have been told before that your code reviews are next to unreadable, > thus next to useless. Wonder why they get so much attention then. :) And this addendum was not so much a review as a demonstration of some very bad code (which had been described as "more powerful" by the creator). It really needed no introduction. > You have also been asked before to take more care > when posting them. Yes. > Suggestions have been made how this could be > accomplished. Yes. > Please do everyone a favor and, as your New Year's > resolution, do not waste more bandwidth like this again. No, I'm sorry, To hell with the bandwidth. |