gSoC - ADD MERGE COMMAND - code patch submission
in [PgSql]
|
Prev: Reworks of DML permission checks
Next: pgsql: Add support for TCPkeepalives on Windows, both for backend and
From: David Fetter on 10 Jul 2010 13:15 On Sat, Jul 10, 2010 at 09:26:38AM -0700, David Fetter wrote: > On Sat, Jul 10, 2010 at 11:52:31AM +0200, Andres Freund wrote: > > On Fri, Jul 09, 2010 at 11:33:04PM -0400, Robert Haas wrote: > > > On Fri, Jul 9, 2010 at 10:25 PM, Boxuan Zhai <bxzhai2010(a)gmail.com> wrote: > > > > Dear All, > > > > > > > > This is ZHAI BOXUAN, a student of gSoC 2010. My project is to add merge > > > > command in postgres. > > > > There is a more detailed instruction in readme. > > I would find it helpfull to find a short recap of how you want to > > handle the various problems (mostly around locking) in the readme. > > > > > > Any comments will be highly appreciated. > > > Is there any chance you can submit this as a single patch file? Or if > > > not, can you at least use a zip or tar file instead of a RAR archive? > > > Ideally the patch would be against CVS HEAD, not 8.4.3. > > > > I would also suggest you base your patch either against the git tree > > or CVS. Currently it does include patches agains generated files like > > gram.y or kwlist.h which make it harder to see the real changes. > > > Please find enclosed a patch against git master as of > 7b2668159bb4d0f5177a23d05bf7c2ab00bc0d75. It works up to make, but > fails on make check. > > I'm thinking the docs for INSERT, UPDATE, and DELETE should link to > the docs for this, as they get written. > > Cheers, > David. Oops. Just noticed that there were 56 lines' worth of C++ style comments, which I've corrected in the enclosed patch, along with some spelling mistakes, grammar, and gratuitous white space. Cheers, David. -- David Fetter <david(a)fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fetter(a)gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate
From: Tom Lane on 10 Jul 2010 13:18 Robert Haas <robertmhaas(a)gmail.com> writes: > Though, if the worst problem with this patch is the formatting, we're doing *quite* well. Well, the worst problem with it is that it hasn't touched the interesting part, ie, what happens at execution time. I haven't seen a design for that, which means it's impossible to evaluate whether the code that is here is of any use. We might need some other representation entirely. BTW, Fetter's version of the patch seems to be lacking any gram.y changes, but surely those exist already? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: David Fetter on 10 Jul 2010 13:39 On Sat, Jul 10, 2010 at 01:18:49PM -0400, Tom Lane wrote: > Robert Haas <robertmhaas(a)gmail.com> writes: > > Though, if the worst problem with this patch is the formatting, we're doing *quite* well. > > Well, the worst problem with it is that it hasn't touched the > interesting part, ie, what happens at execution time. I haven't > seen a design for that, which means it's impossible to evaluate > whether the code that is here is of any use. We might need some > other representation entirely. > > BTW, Fetter's version of the patch seems to be lacking any gram.y > changes, but surely those exist already? Oops. Fixed that now in attached patch. Cheers, David. -- David Fetter <david(a)fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fetter(a)gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate
From: David Fetter on 10 Jul 2010 13:45 On Sat, Jul 10, 2010 at 10:39:02AM -0700, David Fetter wrote: > On Sat, Jul 10, 2010 at 01:18:49PM -0400, Tom Lane wrote: > > Robert Haas <robertmhaas(a)gmail.com> writes: > > > Though, if the worst problem with this patch is the formatting, we're doing *quite* well. > > > > Well, the worst problem with it is that it hasn't touched the > > interesting part, ie, what happens at execution time. I haven't > > seen a design for that, which means it's impossible to evaluate > > whether the code that is here is of any use. We might need some > > other representation entirely. > > > > BTW, Fetter's version of the patch seems to be lacking any gram.y > > changes, but surely those exist already? > > Oops. > > Fixed that now in attached patch. By the way, "make check" fails here with attached initdb.log: ../pg_regress --inputdir=. --dlpath=. --multibyte=SQL_ASCII --temp-install=./tmp_check --top-builddir=../../.. --schedule=./parallel_schedule ============== creating temporary installation ============== ============== initializing database system ============== pg_regress: initdb failed Examine /home/shackle/pggit/postgresql/src/test/regress/log/initdb.log for the reason. Command was: "/home/shackle/pggit/postgresql/src/test/regress/./tmp_check/install//home/shackle/tip/bin/initdb" -D "/home/shackle/pggit/postgresql/src/test/regress/./tmp_check/data" -L "/home/shackle/pggit/postgresql/src/test/regress/./tmp_check/install//home/shackle/tip/share/postgresql" --noclean > "/home/shackle/pggit/postgresql/src/test/regress/log/initdb.log" 2>&1 make[2]: *** [check] Error 2 make[2]: Leaving directory `/home/shackle/pggit/postgresql/src/test/regress' make[1]: *** [check] Error 2 make[1]: Leaving directory `/home/shackle/pggit/postgresql/src/test' make: *** [check] Error 2 Cheers, David. -- David Fetter <david(a)fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fetter(a)gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate
From: Tom Lane on 10 Jul 2010 13:53
David Fetter <david(a)fetter.org> writes: > By the way, "make check" fails here with attached initdb.log: > creating system views ... FATAL: unrecognized token: "false" Hm, I'd suspect something fouled up in keyword recognition. Did you do a "make clean" and rebuild? BTW, this patch is still a few bricks shy of a load, since there's no kwlist.h change and so the new MERGE keyword couldn't possibly be recognized. More generally, I'm wondering why the original .rar submission was 300k (presumably compressed) and your diff is only about 35k ... regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |