gSoC - ADD MERGE COMMAND - code patch submission
in [PgSql]
|
Prev: Reworks of DML permission checks
Next: pgsql: Add support for TCPkeepalives on Windows, both for backend and
From: Boxuan Zhai on 11 Jul 2010 05:18 Hi, Thanks for all these feedback. I found that people have problems on running my codes, which probably comes from my nonstandard submission format. I can compile, install and initialize postgres in my own machine. The system accepts MERGE command and will throw an error when it runs into the executor, which cannot recognize the MERGE command type so far. I will make a standard patch as soon as possible. Sorry for the troubles. Yours Boxuan 2010/7/11 Tom Lane <tgl(a)sss.pgh.pa.us> > Peter Eisentraut <peter_e(a)gmx.net> writes: > > On lör, 2010-07-10 at 12:45 -0400, Tom Lane wrote: > >> I believe the project standard is to make things readable > >> in an 80-column window --- anyone have an objection to stating that > >> explicitly? > > > Is that what pgindent reformats it to? > > pgindent tries to leave a character or two to spare, IIRC, so its target > is probably 78 or thereabouts. > > regards, tom lane >
From: Greg Smith on 12 Jul 2010 10:04 Boxuan Zhai wrote: > I found that people have problems on running my codes, which probably > comes from my nonstandard submission format. I can compile, install > and initialize postgres in my own machine. The system accepts MERGE > command and will throw an error when it runs into the executor, which > cannot recognize the MERGE command type so far. Your job as a potential contributor to PostgreSQL is to make it as easy as possible for others to test your code out and get good results. I sent you some more detailed guidelines over the weekend as to what I think you should do here to achieve that. You should wait until you've gotten a private review from one of the two people who have volunteered to help you out here before you submit anything else to the list. Wasting the time of everyone in the community by sharing code that doesn't mean any of the project guidelines is a very bad idea; please don't do that again. -- Greg Smith 2ndQuadrant US Baltimore, MD PostgreSQL Training, Services and Support greg(a)2ndQuadrant.com www.2ndQuadrant.us -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Peter Eisentraut on 12 Jul 2010 16:28 On mån, 2010-07-12 at 10:04 -0400, Greg Smith wrote: > Wasting the time of everyone in the community by sharing code that > doesn't mean any of the project guidelines is a very bad idea; please > don't do that again. I think it's better to share code that doesn't mean project guidelines and solicit advice rather than not to share anything. -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: "Joshua D. Drake" on 12 Jul 2010 16:32 On Mon, 2010-07-12 at 23:28 +0300, Peter Eisentraut wrote: > On mån, 2010-07-12 at 10:04 -0400, Greg Smith wrote: > > Wasting the time of everyone in the community by sharing code that > > doesn't mean any of the project guidelines is a very bad idea; please > > don't do that again. > > I think it's better to share code that doesn't mean project guidelines > and solicit advice rather than not to share anything. Agreed. It is great that we have guidelines. We should definitely encourage people to use them. We should also lead, not push people into wanting to use them. Collaboration is good. JD -- PostgreSQL.org Major Contributor Command Prompt, Inc: http://www.commandprompt.com/ - 509.416.6579 Consulting, Training, Support, Custom Development, Engineering -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Robert Haas on 12 Jul 2010 19:15
On Jul 12, 2010, at 4:16 PM, Greg Smith <greg(a)2ndquadrant.com> wrote: > I feel the assumption that code is so valuable that it should be shared regardless of whether it meets conventions is a flawed one for this project. There are already dozens, if not hundreds, of useful patch submissions that have been sent to this list, consumed time, and then gone nowhere because they didn't happen in a way that the community was able to integrate them properly. True - but we don't want to unduly discourage potential contributors or make them afraid of posting, either. It is for the community to decide whether the effort to clean up a patch is worthwhile, and to provide guidance on what must change. Individual contributors shouldn't seek to take that process off-list, at least IMHO. The main problem with this patch is not that it was submitted as a RAR of multiple diffs against 8.4.3 instead of a single diff against HEAD: it's that we've apparently reached GSoC midterms without making progress beyond what Peter hacked together whilst sitting in an airport. ....Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |