Prev: Reworks of DML permission checks
Next: pgsql: Add support for TCPkeepalives on Windows, both for backend and
From: Robert Haas on 9 Jul 2010 23:33
On Fri, Jul 9, 2010 at 10:25 PM, Boxuan Zhai <bxzhai2010(a)gmail.com> wrote:
> Dear All,
>
> This is ZHAI BOXUAN, a student of gSoC 2010. My project is to add merge
> command in postgres.
>
> This is the first submission of our codes, which has finished the parser,
> analyzer and rewriter parts.
>
> If you are interested in this project, please download the source code in
> attachment and have test.
>
> There are 3 files in the attachement. Two .patch file is created on the
> /src/backend and /src/include folders (between orignial psql 8.4.3 and our
> modified edition).
>
> There is a more detailed instruction in readme.
>
> Any comments will be highly appreciated.

Is there any chance you can submit this as a single patch file? Or if
not, can you at least use a zip or tar file instead of a RAR archive?

Ideally the patch would be against CVS HEAD, not 8.4.3.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Andres Freund on 10 Jul 2010 05:52
On Fri, Jul 09, 2010 at 11:33:04PM -0400, Robert Haas wrote:
> On Fri, Jul 9, 2010 at 10:25 PM, Boxuan Zhai <bxzhai2010(a)gmail.com> wrote:
> > Dear All,
> >
> > This is ZHAI BOXUAN, a student of gSoC 2010. My project is to add merge
> > command in postgres.
> > There is a more detailed instruction in readme.
I would find it helpfull to find a short recap of how you want to
handle the various problems (mostly around locking) in the readme.

> > Any comments will be highly appreciated.
> Is there any chance you can submit this as a single patch file? Or if
> not, can you at least use a zip or tar file instead of a RAR archive?
> Ideally the patch would be against CVS HEAD, not 8.4.3.

I would also suggest you base your patch either against the git tree
or CVS. Currently it does include patches agains generated files like
gram.y or kwlist.h which make it harder to see the real changes.

Thanks,
Andres

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: David Fetter on 10 Jul 2010 12:26
On Sat, Jul 10, 2010 at 11:52:31AM +0200, Andres Freund wrote:
> On Fri, Jul 09, 2010 at 11:33:04PM -0400, Robert Haas wrote:
> > On Fri, Jul 9, 2010 at 10:25 PM, Boxuan Zhai <bxzhai2010(a)gmail.com> wrote:
> > > Dear All,
> > >
> > > This is ZHAI BOXUAN, a student of gSoC 2010. My project is to add merge
> > > command in postgres.
> > > There is a more detailed instruction in readme.
> I would find it helpfull to find a short recap of how you want to
> handle the various problems (mostly around locking) in the readme.
>
> > > Any comments will be highly appreciated.
> > Is there any chance you can submit this as a single patch file? Or if
> > not, can you at least use a zip or tar file instead of a RAR archive?
> > Ideally the patch would be against CVS HEAD, not 8.4.3.
>
> I would also suggest you base your patch either against the git tree
> or CVS. Currently it does include patches agains generated files like
> gram.y or kwlist.h which make it harder to see the real changes.
>
> Thanks,
> Andres

Please find enclosed a patch against git master as of
7b2668159bb4d0f5177a23d05bf7c2ab00bc0d75. It works up to make, but
fails on make check.

I'm thinking the docs for INSERT, UPDATE, and DELETE should link to
the docs for this, as they get written.

Cheers,
David.
--
David Fetter <david(a)fetter.org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david.fetter(a)gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
From: Tom Lane on 10 Jul 2010 12:45
David Fetter <david(a)fetter.org> writes:
> Please find enclosed a patch against git master as of
> 7b2668159bb4d0f5177a23d05bf7c2ab00bc0d75. It works up to make, but
> fails on make check.

There seem to be about four different comment styles used in this patch,
none of which match the project standard:
http://developer.postgresql.org/pgdocs/postgres/source-format.html

BTW, I notice that that page fails to mention anything about preferred
window width. I believe the project standard is to make things readable
in an 80-column window --- anyone have an objection to stating that
explicitly?

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

From: Robert Haas on 10 Jul 2010 13:03
On Jul 10, 2010, at 11:45 AM, Tom Lane <tgl(a)sss.pgh.pa.us> wrote:
> David Fetter <david(a)fetter.org> writes:
>> Please find enclosed a patch against git master as of
>> 7b2668159bb4d0f5177a23d05bf7c2ab00bc0d75. It works up to make, but
>> fails on make check.
>
> There seem to be about four different comment styles used in this patch,
> none of which match the project standard:
> http://developer.postgresql.org/pgdocs/postgres/source-format.html
>
> BTW, I notice that that page fails to mention anything about preferred
> window width. I believe the project standard is to make things readable
> in an 80-column window --- anyone have an objection to stating that
> explicitly?

I certainly don't.

Though, if the worst problem with this patch is the formatting, we're doing *quite* well.

....Robert
--
Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

 |  Next  |  Last
Pages: 1 2 3 4 5 6
Prev: Reworks of DML permission checks
Next: pgsql: Add support for TCPkeepalives on Windows, both for backend and